Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the CodeSign validation parameters #10392

Conversation

f-alizada
Copy link
Contributor

Context

The optprof pipeline: https://github.com/dotnet/msbuild/blob/main/.opt-prof.yml
Started failing and the error states that vs installer is not found. This is closely related to the changes made for code-sign validation updates: #10299

Changes Made

  • Remove the deletion of vs_enterprise.exe file step from pipeline
  • Add vs_enterprise.exe to exclusion list for code-sign validation

Testing

experimental build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9895530&view=results

@f-alizada f-alizada self-assigned this Jul 17, 2024
@f-alizada f-alizada requested a review from a team as a code owner July 17, 2024 11:36
@f-alizada f-alizada merged commit 47f364c into dotnet:main Jul 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants