-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry entries for BinaryFormatter callsites #6969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[dev16.9.x] NuGet Feed Update
Added accessible name to AnalysisLevelComboBox.
drewnoakes
approved these changes
Feb 18, 2021
...icrosoft.VisualStudio.AppDesigner/PropPageDesigner/PropertyPageSerializationService_Store.vb
Outdated
Show resolved
Hide resolved
swesonga
reviewed
Feb 18, 2021
...icrosoft.VisualStudio.AppDesigner/PropPageDesigner/PropertyPageSerializationService_Store.vb
Outdated
Show resolved
Hide resolved
…lemetry logging before BinaryFormatter calls in callsites. Used const strings for event and property name creation in each TelemetryLogger class.
drewnoakes
approved these changes
Feb 18, 2021
drewnoakes
force-pushed
the
dev16.9.x
branch
from
February 19, 2021 01:59
09c0553
to
9528a30
Compare
# Conflicts: # src/Microsoft.VisualStudio.AppDesigner/Common/Utils.vb
dmonroym
approved these changes
Feb 19, 2021
ghost
added this to the 16.10 milestone
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #6858
The purpose of this PR is to add telemetry logging for all callsites of BinaryFormatter to monitor if they are actually called. Initial testing could only activate one spot, SerializeObject in
ResourceSerializationService_Store.vb
. All other callsites were not able to be activated with a combination of difference projects and usage of the Resource Editor. Therefore, we are adding telemetry and will monitor if there is any valid usage of this code.Currently, we only use
BinaryFormatter
in theAppDesigner
andEditors
projects. These are both VB projects. There are bits and pieces of code that seems copy-pasted between the two. Here, theUtils
file in each project has aTelemetryLogger
class. I've added the same functions to each for logging usage ofBinaryFormatter
. The only difference between the two functions is the telemetry path has the appropriate project, appdesigner and editors respectively.Unfortunately, the site to access the Telemetry Logger application is down. I'll be testing these changes once that site comes back up. But, I wanted to get feedback ASAP since this is for 16.9.
Edit: Even though the site for the app is down, I pulled the code for the logger, built it, and was able to test my changes. Here is a snippet of the log to show the changes are working as expected:
Remember, that's the only function I've been able to activate. But the telemetry events use the same function, so I don't expect issues with the other callsites.
Microsoft Reviewers: Open in CodeFlow