Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Integration Test Failures #38301

Closed
3 tasks
JoeRobich opened this issue Aug 27, 2019 · 2 comments · Fixed by #70635
Closed
3 tasks

Investigate Integration Test Failures #38301

JoeRobich opened this issue Aug 27, 2019 · 2 comments · Fixed by #70635
Assignees

Comments

@JoeRobich
Copy link
Member

JoeRobich commented Aug 27, 2019

5 integration tests are failing regularly in master and master-vs-deps PRs

CSharpUpgradeProject.CPSProject_GeneralPropertyGroupUpdated - System.InvalidOperationException : Expected a light bulb session to appear.
MSBuildWorkspaceTests.TestParseOptions_CSharp_LanguageVersion_Default - Assert.Equal() Failure\r\nExpected: CSharp8\r\nActual: CSharp7_3

The text "To browse the .NET Framework source code" is no longer part of the quick info text for System.String:

BasicQuickInfo.QuickInfo1 - Assert.Equal() Failure\r\n ↓ (pos 72)\r\nExpected: ···f UTF-16 code units.To browse the .NET Framework source code ···\r\nActual: ···f UTF-16 code units.\r\n ↑ (pos 72)
CSharpQuickInfo.QuickInfo_MetadataDocumentation - Assert.Equal() Failure\r\n ↓ (pos 72)\r\nExpected: ···f UTF-16 code units.To browse the .NET Framework source code ···\r\nActual: ···f UTF-16 code units.\r\n ↑ (pos 72)

For Async completion

BasicIntelliSense.IntelliSenseTriggersOnParenWithBraceCompletionAndCorrectUndoMerging - System.AggregateException : One or more errors occurred.\r\n---- System.InvalidOperationException : Expected exactly one session in the completion list, but found 0
  • Skip the affected tests
  • Update the tests to passing
  • Unskip the tests
@JoeRobich
Copy link
Member Author

Seen in #38298 (Test Log), #38229 (Test Log), #38235 (Test Log)

@CyrusNajmabadi
Copy link
Member

Outstanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants