Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment to document the use of the variables in the signed build yml #38298

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Add comment to document the use of the variables in the signed build yml #38298

merged 2 commits into from
Sep 5, 2019

Conversation

JoeRobich
Copy link
Member

as suggested #38259 (comment)

@JoeRobich JoeRobich requested a review from a team as a code owner August 26, 2019 21:52
@JoeRobich
Copy link
Member Author

@jaredpar Please take a look

@JoeRobich JoeRobich force-pushed the dev/jorobich/add-pipeline-comment branch from 6d3d883 to 27941de Compare August 26, 2019 22:15
@JoeRobich JoeRobich mentioned this pull request Aug 27, 2019
Closed
3 tasks
@JoeRobich
Copy link
Member Author

Github checks did not update to reflect passing AzDO Integration tests - https://dev.azure.com/dnceng/public/_build/results?buildId=327027&view=logs&jobId=87d05d67-909a-5802-4a16-de40f014b549

@JoeRobich JoeRobich merged commit a0a99fa into master Sep 5, 2019
@JoeRobich JoeRobich deleted the dev/jorobich/add-pipeline-comment branch September 17, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeRobich @jaredpar