Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support implementation edges for interfaces to types for cross-project/repo find references #59617

Closed
noellelc opened this issue Feb 17, 2022 · 3 comments · Fixed by #64263
Closed

Support implementation edges for interfaces to types for cross-project/repo find references #59617

noellelc opened this issue Feb 17, 2022 · 3 comments · Fixed by #64263
Assignees
@jasonmalinowski
Labels
Area-IDE Concept-Continuous Improvement
Milestone
17.4

Comments

@noellelc
Copy link

The current C# LSIF tool is missing item edges that link implementations to all relevant ranges. The full spec can be found here: https://microsoft.github.io/language-server-protocol/specifications/lsif/0.6.0/specification/. @jasonmalinowski @CyrusNajmabadi

As an example of a missing link:
image
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 17, 2022
@jinujoseph jinujoseph added Area-IDE Concept-Continuous Improvement and removed Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 23, 2022
@jinujoseph jinujoseph added this to the 17.3 milestone Feb 23, 2022
@CyrusNajmabadi
Copy link
Member

I'm not exactly sure what is being asked for here, and i odn't really know anything about this LSIF format. But at first glance, this seems very hard to do as it's asking for reverse links. So we'd have to, per symbol, find all the references to it and then encode that into the final file. Not sure how we can do that efficiently.

@noellelc
Copy link
Author

noellelc commented Apr 28, 2022 via email •
edited by CyrusNajmabadi
Loading

@CyrusNajmabadi
Copy link
Member

@jasonmalinowski i believe you said this would be fairly easy for you to do?

@jasonmalinowski jasonmalinowski modified the milestones: 17.3, 17.4 Jul 6, 2022
@jasonmalinowski jasonmalinowski changed the title Updating the C# LSIF tool to latest spec Support implementation edges for interfaces to types Sep 20, 2022
@jasonmalinowski jasonmalinowski changed the title Support implementation edges for interfaces to types Support implementation edges for interfaces to types for cross-project/repo find references Sep 20, 2022
jasonmalinowski added a commit to jasonmalinowski/roslyn that referenced this issue Sep 24, 2022
@jasonmalinowski
Add support for implementation edges
b7a23d0 
Fixes dotnet#59617
@jasonmalinowski jasonmalinowski mentioned this issue Sep 24, 2022
Merged
jasonmalinowski added a commit to jasonmalinowski/roslyn that referenced this issue Sep 24, 2022
@jasonmalinowski
Add support for implementation edges
e2dd6dc 
Fixes dotnet#59617
jasonmalinowski added a commit to jasonmalinowski/roslyn that referenced this issue Oct 20, 2022
@jasonmalinowski
Add support for implementation edges
a136715 
Fixes dotnet#59617
jasonmalinowski added a commit to jasonmalinowski/roslyn that referenced this issue Oct 20, 2022
@jasonmalinowski
Add support for implementation edges
c178ea6 
Fixes dotnet#59617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonmalinowski jasonmalinowski

Labels
Area-IDE Concept-Continuous Improvement
Projects
None yet
Milestone
17.4
Development

Successfully merging a pull request may close this issue.

Add support for implementation edges in our LSIF indexer jasonmalinowski/roslyn
4 participants
@jasonmalinowski @CyrusNajmabadi @jinujoseph @noellelc