Add support for implementation edges in our LSIF indexer #64263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmalinowski
force-pushed
the
support-implementation-edges
branch
from
b7a23d0
to
e2dd6dc
Compare
jasonmalinowski
commented
Oct 3, 2022
jasonmalinowski
force-pushed
the
support-implementation-edges
branch
from
e2dd6dc
to
a136715
Compare
jasonmalinowski
force-pushed
the
support-implementation-edges
branch
from
a136715
to
c178ea6
Compare
jasonmalinowski
commented
Oct 20, 2022
| MarkImplementationOfSymbol(overridenMember); | ||
| } | ||
|
|
||
| void MarkImplementationOfSymbol(ISymbol baseMember) |
There was a problem hiding this comment.
The only way this will make sense is if you look at the picture in #59617.
2 tasks
dibarbet
approved these changes
Oct 20, 2022
| MarkImplementationOfSymbol(implementedMember); | ||
|
|
||
| // If this overrides a method, we'll also mark it the same way. We want to chase to the base virtual method, skipping over intermediate | ||
| // methods so that way all overrides of the same method point to the same virtual method |
There was a problem hiding this comment.
interesting - I would have thought we would have pointed to intermediate members which themselves point back to the base in a chain. This loses the intermediate member information, but I have no idea if that is OK or not (not sure how this is used).
There was a problem hiding this comment.
We discussed this and decided to go with this way for now. We saw two potential downsides of having the full chain:
- It's not clear what happens if somebody removes their method of an override in the middle of a chain, since then the ends of the chain are disconnected.
- It means a find references in the cloud has to connect all the chains together, as opposed to doing a faster lookup.
So we're going this way for now.
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59617