Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the SyntaxTree and SemanticModel action based analyzers to respect context.FilterSpan #67888

Closed
mavasani opened this issue Apr 20, 2023 · 0 comments · Fixed by #68014
Closed

Move the SyntaxTree and SemanticModel action based analyzers to respect context.FilterSpan #67888

mavasani opened this issue Apr 20, 2023 · 0 comments · Fixed by #68014
Assignees
@mavasani
Labels
Area-IDE Feature Request Performance-Scenario-Diagnostics This issue affects diagnostics computation performance for lightbulb, background analysis, tagger. Tenet-Performance Regression in measured performance of the product from goals. untriaged Issues and PRs which have not yet been triaged by a lead
Milestone
17.7

Comments

@mavasani
Copy link
Contributor

As a follow-up to #67818, we should move all the IDE analyzers that register SyntaxTree and SemanticModel actions to respect context.FilterSpan. Making this change for IDE0055 (Formatting analyzer), shows a significant performance improvement:

FilterSpan
@mavasani mavasani added Area-IDE Feature Request Tenet-Performance Regression in measured performance of the product from goals. labels Apr 20, 2023
@mavasani mavasani added this to the 17.7 milestone Apr 20, 2023
@mavasani mavasani self-assigned this Apr 20, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 20, 2023
mavasani added a commit to mavasani/roslyn that referenced this issue Apr 28, 2023
@mavasani
Move the SyntaxTree and SemanticModel action based analyzers to respe…
82a825f 
…ct context.FilterSpan

Closes dotnet#67888
Follow-up to dotnet#67818
mavasani added a commit to mavasani/roslyn that referenced this issue Apr 28, 2023
@mavasani
Move the SyntaxTree and SemanticModel action based analyzers to respe…
4ed3d82 
…ct context.FilterSpan

Closes dotnet#67888
Follow-up to dotnet#67818
mavasani added a commit to mavasani/roslyn that referenced this issue Apr 28, 2023
@mavasani
Move the SyntaxTree and SemanticModel action based analyzers to respe…
d722c7f 
…ct context.FilterSpan

Closes dotnet#67888
Follow-up to dotnet#67818
mavasani added a commit to mavasani/roslyn that referenced this issue Apr 28, 2023
@mavasani
Move the SyntaxTree and SemanticModel action based analyzers to respe…
58f5e71 
…ct context.FilterSpan

Closes dotnet#67888
Follow-up to dotnet#67818
mavasani added a commit to mavasani/roslyn that referenced this issue Apr 28, 2023
@mavasani
Move the SyntaxTree and SemanticModel action based analyzers to respe…
b12bbde 
…ct context.FilterSpan

Closes dotnet#67888
Follow-up to dotnet#67818
@mavasani mavasani mentioned this issue Apr 28, 2023
Merged
@mavasani mavasani added the Performance-Scenario-Diagnostics This issue affects diagnostics computation performance for lightbulb, background analysis, tagger. label May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavasani mavasani

Labels
Area-IDE Feature Request Performance-Scenario-Diagnostics This issue affects diagnostics computation performance for lightbulb, background analysis, tagger. Tenet-Performance Regression in measured performance of the product from goals. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.7
1 participant
@mavasani