Add FilterSpan API to analyzer contexts #67818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Analyzers
untriaged
mavasani
force-pushed
the
SpanApi
branch
2 times, most recently
from
ba0c6f5
to
f6de5c1
Compare
Closes dotnet#67257 Add FilterSpan public API to SemanticModelAnalysisContext and SyntaxTreeAnalysisContext types to allow analyzers to optimize diagnostic computation for lightbulb code path.
|
@dotnet/roslyn-compiler ping for reviews - this is a simple change which gives us very good performance improvement for lightbulb. |
cston
reviewed
Apr 25, 2023
src/Compilers/Core/Portable/DiagnosticAnalyzer/CompilationWithAnalyzers.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
Apr 25, 2023
src/Compilers/Core/Portable/DiagnosticAnalyzer/CompilationWithAnalyzers.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
Apr 25, 2023
cston
approved these changes
Apr 25, 2023
mavasani
commented
Apr 25, 2023
src/Compilers/Core/Portable/DiagnosticAnalyzer/CompilationWithAnalyzers.cs
Outdated
Show resolved
Hide resolved
mavasani
commented
Apr 25, 2023
src/Compilers/Core/Portable/DiagnosticAnalyzer/CompilationWithAnalyzers.cs
Outdated
Show resolved
Hide resolved
5 tasks
|
Thanks @cston. @dotnet/roslyn-compiler for an additional review. |
jjonescz
approved these changes
Apr 26, 2023
|
Thank you @jjonescz! |
ghost
added this to the
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
Apr 28, 2023
…ct context.FilterSpan Closes dotnet#67888 Follow-up to dotnet#67818
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
Apr 28, 2023
…ct context.FilterSpan Closes dotnet#67888 Follow-up to dotnet#67818
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
Apr 28, 2023
…ct context.FilterSpan Closes dotnet#67888 Follow-up to dotnet#67818
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
Apr 28, 2023
…ct context.FilterSpan Closes dotnet#67888 Follow-up to dotnet#67818
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
Apr 28, 2023
…ct context.FilterSpan Closes dotnet#67888 Follow-up to dotnet#67818
mavasani
added
the
Performance-Scenario-Diagnostics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67257
FilterSpanpublic API toSemanticModelAnalysisContextandSyntaxTreeAnalysisContexttypes to allow analyzers to optimize diagnostic computation for lightbulb code path.CompilationWithAnalyzersto compute syntax diagnosticsPerformance measurements with this change
I wrote a custom standalone tool based on Roslyn NuGet packages that directly loads the compilation and invokes
CompilationWithAnalyzers.GetAnalysisResultAsync(tree, ...)API with and without filterSpan. I am seeing pretty significant performance improvement for the formatting analyzer after this change, see screenshot below. Left side is time to compute full file formatting diagnostics, right side is time to compute span-only formatting diagnostics.