Move logic from the Makefile to either cibuild.sh or build/scripts #21146
Conversation
Also update a couple docs to reflect more modern information. Docs are very out of date at this point, and a review pass should probably be done.
Ignoring until the netci.groovy change gets merged, at which point another PR can be made to remove this ignore.
khyperia
force-pushed
the
refactor_linux_build
branch
from
7216938
to
6c5486c
Compare
| # Temporarily ignore this argument until the change to netci.groovy gets merged. | ||
| # A follow-up PR will be made to remove this ignore. | ||
| shift 1 | ||
| ;; |
There was a problem hiding this comment.
@jaredpar As discussed, this needs to be in this PR until the netci.groovy change (also in this PR) is merged. A follow-up PR removing this will be made at that point.
|
Ping @dotnet/roslyn-infrastructure, ubuntu tests just passed, so this is ready for review. |
|
cc @dpoeschl, integration tests are failing: debug_vs-integration release_vs-integration |
|
I'm investigating, but for now, rerunning (they pass sometimes). |
|
retest windows_release_vs-integration_prtest please |
That's a red herring. I'm going ot remove it so people stop getting confused about it. |
This is a follow-up to PR dotnet#21146, which was unable to be merged without keeping this flag ignore.
This broke in dotnet#21146, but the mac build was not tested.
Also update a couple docs to reflect more modern information. Docs are very out of date at this point, and a review pass should probably be done.
This is an alternative/improvement to #21031. After spending a lot of time reworking the Makefile and simplifying logic, I realized that we're basically using none of the useful features of make, and logic just gets significantly overcomplicated when supporting various operations (using uncommon/advanced make features, which dramatically reduces maintainability).
The mac/linux story, at this point, is good enough to tell users to just
dotnet build CrossPlatform.sln. I've taken the operation of downloading a custom CLI into a user-runnable script (that is also called from CI), as well as extracted theDeployCoreClrTestRuntimeintotests.sh, which now should be user-runnable as well.