-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ignored flag #21167
Remove ignored flag #21167
Conversation
This is a follow-up to PR dotnet#21146, which was unable to be merged without keeping this flag ignore.
Ping @jaredpar, cc @dotnet/roslyn-infrastructure. This is an incredibly simple PR to review 😊 |
... well, tests are failing. I guess I made this PR too soon after merging the previous PR, and the netci.groovy wasn't re-run? Not sure how to fix that. |
retest this please |
The auto-trigger seems like it's still broken. I manually rebuilt the jobs. Should be taking effect now. |
test mac please |
Well, mac doesn't look good. Didn't realize that was a testable thing before merging the previous PR. |
I forgot as well. We don't test it by default because a) mac machines are a limited resource and b) linux is generally a great proxy for mac. Tend to forget about it beacuse it passes so reliably. When I logged in to manually kick off the rebuild of the jobs it reminded me we should test mac here. |
This broke in dotnet#21146, but the mac build was not tested.
test mac please |
Seems like the Mac build hit a flaky build bug?
|
retest mac please |
Never mind, seems to be a consistent failure. I'm not sure how to investigate why this is happening and fix it, advice would be appreciated. (I have no idea what I could have changed that could be causing it) |
Hitting a file lock issue caused by parallel builds
test mac please |
retest windows_debug_vs-integration_prtest please |
retest windows_debug_unit32_prtest please |
@khyperia All green! |
Thanks @dpoeschl! 😄 |
This is a follow-up to PR #21146, which was unable to be merged without
keeping this flag ignore.