Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ignored flag #21167

Merged
merged 3 commits into from
Jul 28, 2017
Merged

Remove ignored flag #21167

merged 3 commits into from
Jul 28, 2017

Conversation

khyperia
Copy link
Contributor

This is a follow-up to PR #21146, which was unable to be merged without
keeping this flag ignore.

@khyperia
Remove ignored flag
c52d9f6 
This is a follow-up to PR dotnet#21146, which was unable to be merged without
keeping this flag ignore.
@khyperia
Copy link
Contributor Author

Ping @jaredpar, cc @dotnet/roslyn-infrastructure. This is an incredibly simple PR to review 😊

@khyperia
Copy link
Contributor Author

... well, tests are failing. I guess I made this PR too soon after merging the previous PR, and the netci.groovy wasn't re-run? Not sure how to fix that.

@jaredpar
Copy link
Member

retest this please

@jaredpar
Copy link
Member

The auto-trigger seems like it's still broken. I manually rebuilt the jobs. Should be taking effect now.

@jaredpar
Copy link
Member

test mac please

@khyperia
Copy link
Contributor Author

Well, mac doesn't look good. Didn't realize that was a testable thing before merging the previous PR.

@jaredpar
Copy link
Member

I forgot as well. We don't test it by default because a) mac machines are a limited resource and b) linux is generally a great proxy for mac. Tend to forget about it beacuse it passes so reliably. When I logged in to manually kick off the rebuild of the jobs it reminded me we should test mac here.

@khyperia
Set HOME if it is not set in the CI build
cec4b26 
This broke in dotnet#21146, but the mac build was not tested.
@khyperia
Copy link
Contributor Author

test mac please

@khyperia
Copy link
Contributor Author

Seems like the Mac build hit a flaky build bug?

The "GenerateDepsFile" task failed unexpectedly. [src/Scripting/CoreTestUtilities/ScriptingTestUtilities.csproj]
System.IO.IOException: The process cannot access the file 'Binaries/Debug/Dlls/ScriptingTestUtilities/Microsoft.CodeAnalysis.Scripting.TestUtilities.deps.json' because it is being used by another process.

@khyperia
Copy link
Contributor Author

retest mac please

@khyperia
Copy link
Contributor Author

Never mind, seems to be a consistent failure. I'm not sure how to investigate why this is happening and fix it, advice would be appreciated. (I have no idea what I could have changed that could be causing it)

@jaredpar jaredpar mentioned this pull request Jul 27, 2017
Closed
@khyperia
Set /maxcpucount:1 for Linux/Mac builds
e6a8433 
Hitting a file lock issue caused by parallel builds
@khyperia
Copy link
Contributor Author

test mac please

@dpoeschl
Copy link
Contributor

dpoeschl commented Jul 27, 2017 •
edited
Loading

retest windows_debug_vs-integration_prtest please
Failure: test hang that's being investigated

@dpoeschl
Copy link
Contributor

dpoeschl commented Jul 27, 2017 •
edited
Loading

retest windows_debug_unit32_prtest please
https://ci.dot.net/job/dotnet_roslyn/job/master/job/windows_debug_unit32_prtest/8566/

@dpoeschl
Copy link
Contributor

@khyperia All green!

@jaredpar jaredpar merged commit 3a8dca3 into dotnet:master Jul 28, 2017
@khyperia
Copy link
Contributor Author

Thanks @dpoeschl! 😄

@khyperia khyperia deleted the remove_flag branch July 28, 2017 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khyperia @jaredpar @dpoeschl @dnfclas