Merge features/compiler into features/record-structs #52647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* EnC: Don't consider changing unsafe modifier as rude edit * Add test for partial and unsafe * Update issue link
Enable test for fixed Smart Break Line issue
…fault Enable Remove Unused References by default
Simplify navigate to code.
Move IDE0066 'ContainsDirectives' check from analyzer to code fix
…o-main Merge release/dev16.10 to main
Fixes [AB#1128126](https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1128126) Currently, the global option service only tracks explicitly changed option keys. This means options that have non-default values from option persisters are not part of tracked changed option keys, which leads to GlobalOptionService.SetOptions to ignore these options until an actual new solution snapshot is produced with the non-default option value. Verified customer repro and added unit test failure prior to the fix.
* Replace iff with "if and only if" Fixes dotnet/docs#21572 * replace "iff" with "if and only if" in other public `///` locations PR review pointed to two other locations where "iff" was used in the /// comments. This commit replaces those with "if and only if" in those cases where the API is public, or protected and will be part of the documentation set. There are other uses in comments, include `///` comments on internal (or Friend) APIs and private methods. Those are unchanged.
Fix global option service to handle non-default values from persisters
* Make order of extension loading deterministic * Add tests and make allExtensions deterministic too
…-tokens-editorfeatures Pass CancellationTokens in the EditorFeature layer
…-tokens-features Pass CancellationToken at Features layer
…methods Reuse existing extension methods
Rev codestyle version to 3.9
…OnPropertyAccess UsePatternCombinator: Fix wrong target equivalence comparison.
* Rebuild PDB documentation Get the rebuild PDB documentation up to date with our recent changes * Escape the |
Don't push diagnostics for LSP documents if Pull-diags are enabled.
* Factor out interface for source and references This adds the abstraction `IRebuildArtifactResolver` to the Rebuild layer. This interface abstracts out the finding of the source and references to the host process. The validator and tests were then changed to leverage this interface in testing. As a proof of this working I extended our tests to include `/pathmap` tests. These all failed before the change due to the file paths not lining up in the re-used `SyntaxTree` instances * PR feedback
Extract Method Highlight Part of Switch Expression Bug Fix
Refresh features/compiler with latest bits from main branch
jcouv
force-pushed
the
merge-features-compiler
branch
from
91e9ca6
to
215d47b
Compare
AlekseyTs
approved these changes
Apr 15, 2021
Are we supporting record-classes there? If so, we should get parity with record-structs. If we're not doing record classes there, then no. |
|
@CyrusNajmabadi Cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler side was just minor/usual conflicts on messageID and resource files. Trivial to resolve.
I resolved a few conflicts in EditorFeatures (some code had moved or was refactored).
Also realized I'd left two PROTOTYPE comments in CSharpCodeModelService (a feature still being worked on by IDE team). @CyrusNajmabadi Let me know if you'd like a tracking issue for adding support to record structs to that new feature.
Test plan: #51199