Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record-structs: merge feature into features/compiler branch #52671

Closed
wants to merge 301 commits into from

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Apr 16, 2021

Test plan: #51199

jaredpar and others added 17 commits April 19, 2021 07:21
…nly analyzer

Fixes #50925
Note that we only pass in the `Analyze` flag, not the `ReportDiagnostics` flag, so that fields defined in generated code are not flagged.
Ensure that we register to analyze generated code for MakeFieldReadO…
[main] Update dependencies from dotnet/roslyn
…-targeting

Fix build of our .NET 2.0-targeting projects
* Use compile-time solution for solution crawler and EnC

* Only remove design-time docs when enc config file is present

* Only enable when Razor LSP editor is enabled
'Simplify interpolation' should not be suggested in VB for non-literal alignments
@jcouv jcouv marked this pull request as draft April 20, 2021 05:48
@jcouv jcouv marked this pull request as ready for review April 22, 2021 05:40
Support record structs in complete statement command
@jcouv
Copy link
Member Author

jcouv commented Apr 22, 2021

GitHub is completely confused. It is showing way too many commits. Opening up a new PR to resolve this...

@jcouv jcouv closed this Apr 22, 2021
@jcouv
Copy link
Member Author

jcouv commented Apr 22, 2021

Here's the replacement PR: #52844
It looks fine (only lists commits/diffs that I expect)

@jcouv jcouv deleted the features/record-structs branch April 25, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.