Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion: Suggest "await" after dot of awaitable expression #55817

Merged
merged 107 commits into from
Oct 19, 2021
Merged

Completion: Suggest "await" after dot of awaitable expression #55817

merged 107 commits into from
Oct 19, 2021

Commits on Aug 23, 2021

  1. Suggest "await" after dotting an awaitable expression (suggestion onl… 

    …y, commit behavior tbd).
    @MaStr11
    MaStr11 committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    ca1226b View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. WIP: 

    Move logic from SyntaxContext to AbstractAwaitCompletionProvider
Check IsAwaitKeywordContext on insertion position
Prepare support for DottedAwait in GetChangeAsync
    @MaStr11
    MaStr11 committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    56ab5cf View commit details
    Browse the repository at this point in the history

  2. CS Completion for await and async

    @MaStr11
    MaStr11 committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    3b169f8 View commit details
    Browse the repository at this point in the history

  3. Rename some tests

    @MaStr11
    MaStr11 committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    d138ad7 View commit details
    Browse the repository at this point in the history

  4. Add tests for ValueTask and CustomAwaiter

    @MaStr11
    MaStr11 committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    244e40a View commit details
    Browse the repository at this point in the history

  5. Add support for cursor in the middle of DotDot token

    @MaStr11
    MaStr11 committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    6db9239 View commit details
    Browse the repository at this point in the history

  6. Add support for corner cases

    @MaStr11
    MaStr11 committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    5ff9d09 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. Fix formatting

    @MaStr11
    MaStr11 committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    a32ccbc View commit details
    Browse the repository at this point in the history

  2. Simplify test

    @MaStr11
    MaStr11 committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    d0fae3c View commit details
    Browse the repository at this point in the history

  3. GetMarkup: Enclose {source} in CDATA

    @MaStr11
    MaStr11 committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    e94955c View commit details
    Browse the repository at this point in the history

  4. Add tests for different expressions.

    @MaStr11
    MaStr11 committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    f2b6774 View commit details
    Browse the repository at this point in the history

  5. Don't offer on the Task type

    @MaStr11
    MaStr11 committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    00aab7a View commit details
    Browse the repository at this point in the history

  6. Change delgate test case

    @MaStr11
    MaStr11 committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    07d2455 View commit details
    Browse the repository at this point in the history

  7. Small test enhancements.

    @MaStr11
    MaStr11 committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    5e6e6d0 View commit details
    Browse the repository at this point in the history

  8. Add completion test for different expressions

    @MaStr11
    MaStr11 committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    b8c0e43 View commit details
    Browse the repository at this point in the history

  9. Add support for "ConfigureAwait" with one end-to-end test

    @MaStr11
    MaStr11 committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    8d1b928 View commit details
    Browse the repository at this point in the history

  10. Get syntaxKinds from syntaxFacts 

    Co-authored-by: CyrusNajmabadi <[email protected]>
    @MaStr11 @CyrusNajmabadi
    MaStr11 and CyrusNajmabadi authored Aug 25, 2021
    Configuration menu
    Copy the full SHA
    1831669 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. Use compilation.TaskType() for the IsConfigureAwaitable check.

    @MaStr11
    MaStr11 committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    c2fe20a View commit details
    Browse the repository at this point in the history

  2. Refactor GetTypeSymbolOfExpression

    @MaStr11
    MaStr11 committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    74b7b20 View commit details
    Browse the repository at this point in the history

  3. Refactoring: Replace CompletionChangeEdit enum with keys in completio… 

    …n properties.
    @MaStr11
    MaStr11 committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    808fe46 View commit details
    Browse the repository at this point in the history

  4. Revert changes in GetTypeSymbolOfExpression

    @MaStr11
    MaStr11 committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    97e7956 View commit details
    Browse the repository at this point in the history

  5. Use CompletionItem.FilterText to force "af" to select awaitf from the… 

    … completion list.
    @MaStr11
    MaStr11 committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    e6e840b View commit details
    Browse the repository at this point in the history

  6. Change DotAwaitCompletionAddsAwaitInFrontOfExpressionForDifferentExpr… 

    …essions to test different await/awaitf/makeContainerAsync combinations.
    @MaStr11
    MaStr11 committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    5311982 View commit details
    Browse the repository at this point in the history

  7. Add suggestion tests for await in lambdas

    @MaStr11
    MaStr11 committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    66e8960 View commit details
    Browse the repository at this point in the history

  8. Move test case

    @MaStr11
    MaStr11 committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    bf645ef View commit details
    Browse the repository at this point in the history

  9. Transport targetToken position into GetChangeAsync. Addresses bugs, b… 

    …ecause root.FindToken(item.Span.Start) finds other tokens as SyntaxContext.TargetToken
    @MaStr11
    MaStr11 committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    e09ef9f View commit details
    Browse the repository at this point in the history

  10. Add combinatorial test for completion in lambdas.

    @MaStr11
    MaStr11 committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    ce779cd View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. Avoid the "local" completion bug in tests and enable "locals" test ca… 

    …ses (use "Task" instead of "var" to help the type inferencer)
    @MaStr11
    MaStr11 committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    189892d View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. Add range operator test.

    @MaStr11
    MaStr11 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    dd6325c View commit details
    Browse the repository at this point in the history

  2. Fix VB AwaitCompletionProviderTests

    @MaStr11
    MaStr11 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    d241013 View commit details
    Browse the repository at this point in the history

  3. VB: Add DotAwaitInAsyncSub test

    @MaStr11
    MaStr11 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    5e5fbc9 View commit details
    Browse the repository at this point in the history

  4. Implement abstract members in VBs AwaitCompletionProvider

    @MaStr11
    MaStr11 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    2498bcb View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. VB: WalkDownParentheses on MemberaccessExpression.Expression

    @MaStr11
    MaStr11 committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    dd8f7fd View commit details
    Browse the repository at this point in the history

  2. Convert remaining C# tests to VB (Part 1)

    @MaStr11
    MaStr11 committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    08f5386 View commit details
    Browse the repository at this point in the history

  3. Convert remaining C# tests to VB (Part 2)

    @MaStr11
    MaStr11 committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    6fa6ab7 View commit details
    Browse the repository at this point in the history

  4. VB: Exclude Query context from Await completion

    @MaStr11
    MaStr11 committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    f4305ca View commit details
    Browse the repository at this point in the history

  5. Convert C# completion tests to VB (part 1)

    @MaStr11
    MaStr11 committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    293ab38 View commit details
    Browse the repository at this point in the history

  6. Convert C# completion tests to VB (part 2)

    @MaStr11
    MaStr11 committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    27cedea View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. Merge branch 'main' into AwaitCompletionAfterDot

    @MaStr11
    MaStr11 authored Sep 2, 2021
    Configuration menu
    Copy the full SHA
    e5d2d98 View commit details
    Browse the repository at this point in the history

  2. Fix build errors after merge of main

    @MaStr11
    MaStr11 committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    8742e3c View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. Rename includeingAwaitf parameter to awaitf

    @MaStr11
    MaStr11 committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    581c422 View commit details
    Browse the repository at this point in the history

  2. Move GetDotAwaitKeywordContext to base class.

    @MaStr11
    MaStr11 committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    07a8f56 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2021

  1. Add completion item description for "dotAwait"

    @MaStr11
    MaStr11 committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    78ebf77 View commit details
    Browse the repository at this point in the history

  2. Add xlf files

    @MaStr11
    MaStr11 committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    01efce1 View commit details
    Browse the repository at this point in the history

  3. C#: Add support for "expectedDescriptionOrNull" in AwaitCompletionPro… 

    …viderTests.
    @MaStr11
    MaStr11 committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    bb72f5b View commit details
    Browse the repository at this point in the history

  4. VB: Add support for "expectedDescriptionOrNull" in AwaitCompletionPro… 

    …viderTests.
    @MaStr11
    MaStr11 committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    83b560e View commit details
    Browse the repository at this point in the history

  5. VB Tests: Fix missing expectedDescription handling in awaitf case

    @MaStr11
    MaStr11 committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    4b7cd02 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Formatting and refactorings in VerifyKeywordAsync

    @MaStr11
    MaStr11 committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    0fcd688 View commit details
    Browse the repository at this point in the history

  2. Add partially written "await" tests to C#: DotAwaitCompletionAddsAwai… 

    …tInFrontOfExpressionInLambdas
    @MaStr11
    MaStr11 committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    ab7dc34 View commit details
    Browse the repository at this point in the history

  3. C# test: Make sure, awaitf is not suggested on a custom awaitable, ev… 

    …en if ConfigureAwait is present.
    @MaStr11
    MaStr11 committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    2d9a142 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into AwaitCompletionAfterDot

    @MaStr11
    MaStr11 authored Sep 7, 2021
    Configuration menu
    Copy the full SHA
    c03b284 View commit details
    Browse the repository at this point in the history

  5. Document formatting

    @MaStr11
    MaStr11 committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    17f2bdd View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Be more explicit about the exact syntaxtree in GetAsyncSupportingDecl… 

    …aration that causes the misinterpretation as LocalFunctionStatementSyntax
    @MaStr11
    MaStr11 committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    cabd453 View commit details
    Browse the repository at this point in the history

  2. IsConfigureAwaitable: Add ValueTask

    @MaStr11
    MaStr11 committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    ca6b9ec View commit details
    Browse the repository at this point in the history

  3. Add workitem for skipped test TestDotAwaitSuggestBeforeLocalFunction

    @MaStr11
    MaStr11 committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    dd34761 View commit details
    Browse the repository at this point in the history

  4. Add completion tests if "ConfigureAwait(false)" is already present.

    @MaStr11
    MaStr11 committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    bc86dca View commit details
    Browse the repository at this point in the history

  5. Refactor VB memberAccess cast 

    Co-authored-by: CyrusNajmabadi <[email protected]>
    @MaStr11 @CyrusNajmabadi
    MaStr11 and CyrusNajmabadi authored Sep 8, 2021
    Configuration menu
    Copy the full SHA
    8e78404 View commit details
    Browse the repository at this point in the history

  6. Remove line 

    Co-authored-by: CyrusNajmabadi <[email protected]>
    @MaStr11 @CyrusNajmabadi
    MaStr11 and CyrusNajmabadi authored Sep 8, 2021
    Configuration menu
    Copy the full SHA
    6f0da29 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Refactor DotAwaitCompletionAddsAwaitInFrontOfExpressionInLambdas

    @MaStr11
    MaStr11 committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    5c7c1ed View commit details
    Browse the repository at this point in the history

  2. Refactor DotAwaitCompletionAddsAwaitInFrontOfExpressionInLambdas: Mak… 

    …e the awaitf case more readable
    @MaStr11
    MaStr11 committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    2de160c View commit details
    Browse the repository at this point in the history

  3. Change "private protected" to "protected"

    @MaStr11
    MaStr11 committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    b564816 View commit details
    Browse the repository at this point in the history

  4. Rename ShouldBeTreatedAsTypeInsteadOfExpression to ShouldNameExpressi… 

    …onBeTreatedAsExpressionInsteadOfType
    @MaStr11
    MaStr11 committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    e3658fa View commit details
    Browse the repository at this point in the history

  5. Don't say "awaitf-Keyword" in description.

    @MaStr11
    MaStr11 committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    4da09b7 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'AwaitCompletionAfterDot' of https://github.com/MaStr11/… 

    …roslyn into AwaitCompletionAfterDot
    @MaStr11
    MaStr11 committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    d94e9de View commit details
    Browse the repository at this point in the history

  7. Add test cases for VB query expressions.

    @MaStr11
    MaStr11 committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    cd69af1 View commit details
    Browse the repository at this point in the history

  8. VB: Await in Query clause: IsAwaitKeywordContext returns true in case… 

    …s defined by the spec.
    @MaStr11
    MaStr11 committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    45771df View commit details
    Browse the repository at this point in the history

  9. Add commit test for VB in query

    @MaStr11
    MaStr11 committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    6c80fc5 View commit details
    Browse the repository at this point in the history

  10. C#: Add support for Await in Query: From clause

    @MaStr11
    MaStr11 committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    ad9abb4 View commit details
    Browse the repository at this point in the history

  11. C#: Add support for Await in Query: Join clause

    @MaStr11
    MaStr11 committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    ec72d9f View commit details
    Browse the repository at this point in the history

  12. C#: await in query completion tests

    @MaStr11
    MaStr11 committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    0d892bf View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2021

  1. Null forgiving operator: Add test for "offer await".

    @MaStr11
    MaStr11 committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    ab23585 View commit details
    Browse the repository at this point in the history

  2. Completion test for null forgiving operator.

    @MaStr11
    MaStr11 committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    b98212c View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. Merge remote-tracking branch 'upstream/main' into AwaitCompletionAfte… 

    …rDot
    @MaStr11
    MaStr11 committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    047d098 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. Merge remote-tracking branch 'upstream/main' into AwaitCompletionAfte… 

    …rDot
    @MaStr11
    MaStr11 committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    8875d87 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into AwaitCompletionAfte… 

    …rDot
    @MaStr11
    MaStr11 committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    5c5a96c View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2021

  1. Merge remote-tracking branch 'upstream/main' into AwaitCompletionAfte… 

    …rDot
    @CyrusNajmabadi
    CyrusNajmabadi committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    6a9cba9 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. Fix typo

    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    ad4ef46 View commit details
    Browse the repository at this point in the history

  2. Make LanguageVersion optional

    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    2616001 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: CyrusNajmabadi <[email protected]>
    @MaStr11 @CyrusNajmabadi
    MaStr11 and CyrusNajmabadi authored Oct 13, 2021
    Configuration menu
    Copy the full SHA
    2e8631a View commit details
    Browse the repository at this point in the history

  4. Mark ConfigureAwait as locked in resx.

    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    b951736 View commit details
    Browse the repository at this point in the history

  5. xlf generated

    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    3e65e5b View commit details
    Browse the repository at this point in the history

  6. Revert some changes from CodeReview and fix compile errors

    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    9299d86 View commit details
    Browse the repository at this point in the history

  7. Refactor GetTypeSymbolOfExpression.

    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    48f91b5 View commit details
    Browse the repository at this point in the history

  8. Remove private static class AwaitCompletionChange

    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    5c40d56 View commit details
    Browse the repository at this point in the history

  9. Debug.Fail instead of Debug.Assert false

    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    3b80d14 View commit details
    Browse the repository at this point in the history

  10. IsAwaitableNonDynamic is handling null and is annotated (NotNullWhenT… 

    …rue)
    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    e0db13d View commit details
    Browse the repository at this point in the history

  11. Make syntactic checks before semantic.

    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    80543c2 View commit details
    Browse the repository at this point in the history

  12. Add yield break; before local function

    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    d25bb3b View commit details
    Browse the repository at this point in the history

  13. Inline AddKey helper method.

    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    e445020 View commit details
    Browse the repository at this point in the history

  14. Unify GetDotTokenLeftOfPosition between AwaitCompletionProvider and U… 

    …nnamedSymbolCompletionProvider
    @MaStr11
    MaStr11 committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    53ac841 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. Remove "Make container async" inline description.

    @MaStr11
    MaStr11 committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    5020a2f View commit details
    Browse the repository at this point in the history

  2. Remove unsed parameter after removal of inlineDescription

    @MaStr11
    MaStr11 committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    a47d491 View commit details
    Browse the repository at this point in the history

  3. Cache and lazy evaluate awaitDisplayText, falseKeyword, awaitfDisplay… 

    …Text and awaitfFilterText
    @MaStr11
    MaStr11 committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    71aa4c6 View commit details
    Browse the repository at this point in the history

  4. Remove unused makeContainerAsync parameter from VB test

    @MaStr11
    MaStr11 committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    e8dfec2 View commit details
    Browse the repository at this point in the history

  5. Add some more tests for statements after the dot

    @MaStr11
    MaStr11 committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    72c214a View commit details
    Browse the repository at this point in the history

  6. Remove unused makeContainerAsync parameter in VB tests

    @MaStr11
    MaStr11 committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    7624178 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. Merge remote-tracking branch 'upstream/main' into AwaitCompletionAfte… 

    …rDot
    @CyrusNajmabadi
    CyrusNajmabadi committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    3e1c2d1 View commit details
    Browse the repository at this point in the history

  2. Simplify

    @CyrusNajmabadi
    CyrusNajmabadi committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    59154fc View commit details
    Browse the repository at this point in the history

  3. Invert

    @CyrusNajmabadi
    CyrusNajmabadi committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    02d98b5 View commit details
    Browse the repository at this point in the history

  4. Simplify

    @CyrusNajmabadi
    CyrusNajmabadi committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    69d5a74 View commit details
    Browse the repository at this point in the history

  5. Cleanup

    @CyrusNajmabadi
    CyrusNajmabadi committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    1e6544d View commit details
    Browse the repository at this point in the history

  6. Make private and inline

    @CyrusNajmabadi
    CyrusNajmabadi committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    7f88a26 View commit details
    Browse the repository at this point in the history

  7. Simplify

    @CyrusNajmabadi
    CyrusNajmabadi committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    9e6144e View commit details
    Browse the repository at this point in the history

  8. Simplify

    @CyrusNajmabadi
    CyrusNajmabadi committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    d0d5a39 View commit details
    Browse the repository at this point in the history

  9. cleanup imports

    @CyrusNajmabadi
    CyrusNajmabadi committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    f0ebe68 View commit details
    Browse the repository at this point in the history

  10. Consistent impl

    @CyrusNajmabadi
    CyrusNajmabadi committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    4653402 View commit details
    Browse the repository at this point in the history

  11. Deal with no token found

    @CyrusNajmabadi
    CyrusNajmabadi committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    5f4f162 View commit details
    Browse the repository at this point in the history