Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion: Suggest "await" after dot of awaitable expression #55817

Merged
merged 107 commits into from
Oct 19, 2021
Merged

Completion: Suggest "await" after dot of awaitable expression #55817

merged 107 commits into from
Oct 19, 2021

Conversation

MaStr11
Copy link
Contributor

@MaStr11 MaStr11 commented Aug 23, 2021

Fixes #52289

someTask.aw$$ // this triggers completion which contains "await" and "awaitf".
// committed suggestions "await":
await someTask$$
// or "awaitf"
await someTask.ConfigureAwait(false)$$

@MaStr11
WIP:
56ab5cf 
Move logic from SyntaxContext to AbstractAwaitCompletionProvider
Check IsAwaitKeywordContext on insertion position
Prepare support for DottedAwait in GetChangeAsync
@MaStr11
CS Completion for await and async
3b169f8
@MaStr11
Rename some tests
d138ad7
@MaStr11
Add tests for ValueTask and CustomAwaiter
244e40a
@MaStr11
Add support for cursor in the middle of DotDot token
6db9239
@MaStr11
Add support for corner cases
5ff9d09
@CyrusNajmabadi
Copy link
Member

This is looking really good :)

@MaStr11
Copy link
Contributor Author

MaStr11 commented Oct 14, 2021

@CyrusNajmabadi Ready for review. All the recent feedback is addressed and the crucial CI checks are green. Have you seen this older #55817 (comment)?

@CyrusNajmabadi
Copy link
Member

Approved. Thanks for the contribution @MaStr11 !

@CyrusNajmabadi CyrusNajmabadi merged commit 2029446 into dotnet:main Oct 19, 2021
@ghost ghost added this to the Next milestone Oct 19, 2021
@MaStr11 MaStr11 deleted the AwaitCompletionAfterDot branch October 20, 2021 07:34
@RikkiGibson RikkiGibson modified the milestones: Next, 17.1.P1 Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees

@CyrusNajmabadi CyrusNajmabadi

Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. Feature Request
Projects
None yet
Milestone
17.1.P1
Development

Successfully merging this pull request may close these issues.

Suggestion for unnamed symbols completion: Offer completion for await
4 participants
@MaStr11 @CyrusNajmabadi @RikkiGibson @jinujoseph