Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/dev17.3 to main #61060

Merged
merged 7 commits into from
May 3, 2022
Merged

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from release/dev17.3 into main.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/release/dev17.3-to-main
git reset --hard upstream/main
git merge upstream/release/dev17.3
# Fix merge conflicts
git commit
git push upstream merges/release/dev17.3-to-main --force

tmat and others added 4 commits April 27, 2022 13:09
* Allow non-Roslyn languages to use Formatter API

* Custom document options provider

* Fix typo
…ed (#60973)

Fixes AB#1524181

Tested locally and command invocation works as expected. The initialization was causing package loads while the Roslyn package was initializing. We can wait until needed, and likely those packages are loaded by then anyways.
@dotnet-bot dotnet-bot requested a review from a team as a code owner April 30, 2022 00:02
@dotnet-bot dotnet-bot force-pushed the merges/release/dev17.3-to-main branch from 3b46d46 to b1ee655 Compare April 30, 2022 00:02
@dotnet-bot dotnet-bot added Area-Infrastructure auto-merge Merge Conflicts There are merge conflicts with the base branch. labels Apr 30, 2022
@dotnet-bot
Copy link
Collaborator Author

⚠ This PR has merge conflicts. @dibarbet

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@dotnet-bot dotnet-bot requested review from a team as code owners May 3, 2022 00:08
@dotnet-bot dotnet-bot merged commit 090b418 into main May 3, 2022
@ghost ghost added this to the Next milestone May 3, 2022
@Cosifne Cosifne modified the milestones: Next, 17.3 P2 May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure auto-merge Merge Conflicts There are merge conflicts with the base branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants