Use SegmentedHashSet<T> to eliminate LOH allocations in AsyncBatchingWorkQueue #61276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was there a particular ABWQ that was showing high allocs here? |
CyrusNajmabadi
approved these changes
May 12, 2022
genlu
approved these changes
May 12, 2022
|
@CyrusNajmabadi Someone reported it from local review of Speedometer data. Don't know if there was an issue filed for it or if it was just opportunistic. |
|
@sharwell SGTM, thanks! If you do find the info, i'd def like to know. This PR is pure goodness on it's own. But it might be that that particular area might deserve some deeper looking at to see if htere's more improvement to make there. |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.