Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SegmentedHashSet<T> to eliminate LOH allocations in AsyncBatchingWorkQueue #61276

Merged
merged 1 commit into from
May 13, 2022
Merged

Use SegmentedHashSet<T> to eliminate LOH allocations in AsyncBatchingWorkQueue #61276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Workspaces/Core/Portable/Shared/Utilities/AsyncBatchingWorkQueue`2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ internal class AsyncBatchingWorkQueue<TItem, TResult>
/// Used if <see cref="_equalityComparer"/> is present to ensure only unique items are added to <see
/// cref="_nextBatch"/>.
/// </summary>
private readonly HashSet<TItem> _uniqueItems;
private readonly SegmentedHashSet<TItem> _uniqueItems;

/// <summary>
/// Task kicked off to do the next batch of processing of <see cref="_nextBatch"/>. These
Expand Down Expand Up @@ -86,7 +86,7 @@ public AsyncBatchingWorkQueue(
_asyncListener = asyncListener;
_cancellationToken = cancellationToken;

_uniqueItems = new HashSet<TItem>(equalityComparer);
_uniqueItems = new SegmentedHashSet<TItem>(equalityComparer);
}

public void AddWork(TItem item)
Expand Down