Add ScopedKind to IParameterSymbol and ILocalSymbol #64190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cston
commented
Sep 23, 2022
| /// <summary> | ||
| /// Enumeration for kinds of scoped modifiers. | ||
| /// </summary> | ||
| public enum ScopedKind |
cston
commented
Sep 23, 2022
| // https://github.com/dotnet/roslyn/issues/61647: Internally, scope is represented with this enum, | ||
| // but the public API uses a pair of IsRefScoped and IsValueScoped bools (see ILocalSymbol, | ||
| // IParameterSymbol, and ScopedRefAttribute). We should have a common representation. | ||
| // And we should use common terms for the attribute and enum names. | ||
| internal enum DeclarationScope : byte |
There was a problem hiding this comment.
Seems like it would be a reasonable change.
AlekseyTs
reviewed
Sep 23, 2022
| @@ -22,6 +22,11 @@ public interface IParameterSymbol : ISymbol | |||
| /// </summary> | |||
| RefKind RefKind { get; } | |||
|
|
|||
| /// <summary> | |||
| /// Returns the scoped kind of the local. | |||
AlekseyTs
reviewed
Sep 23, 2022
| None = 0, | ||
|
|
||
| /// <summary> | ||
| /// A ref scoped to the current method or block. |
AlekseyTs
reviewed
Sep 23, 2022
| if ((symbol as Symbols.PublicModel.ParameterSymbol)?.GetSymbol<ParameterSymbol>() is { } parameter && | ||
| parameter.EffectiveScope == DeclarationScope.RefScoped && | ||
| if (symbol.ScopedKind == ScopedKind.ScopedRef && | ||
| (symbol as Symbols.PublicModel.ParameterSymbol)?.GetSymbol<ParameterSymbol>() is { } parameter && | ||
| !ParameterHelpers.IsRefScopedByDefault(parameter) && |
There was a problem hiding this comment.
Are we missing IsRefScopedByDefault as a public API? Is there an alternative way to detect this in a language independent way? #Closed
There was a problem hiding this comment.
If not, perhaps we should use this condition only for C# symbols and not dismiss other symbols?
There was a problem hiding this comment.
IsRefScopedByDefault() relies on ModuleSymbol.UsesUpdatedEscapeRules, which is not tracked in VB, nor is scoped. Changed to use for C# symbols only.
|
Done with review pass (commit 3) |
333fred
approved these changes
Sep 23, 2022
| // https://github.com/dotnet/roslyn/issues/61647: Internally, scope is represented with this enum, | ||
| // but the public API uses a pair of IsRefScoped and IsValueScoped bools (see ILocalSymbol, | ||
| // IParameterSymbol, and ScopedRefAttribute). We should have a common representation. | ||
| // And we should use common terms for the attribute and enum names. | ||
| internal enum DeclarationScope : byte |
There was a problem hiding this comment.
Seems like it would be a reasonable change.
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #61647.