Extract a few more interfaces from the VS layer project system #65799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what we report analyzer load issues through; this probably needs a larger refactoring because: 1. I'm not sure why we have both the base type and derived type, since there's only one inheriting from the base type. 2. Much of this is used for analyzer dependency conflict checking, which is perhaps of limited use in the first place.
jasonmalinowski
force-pushed
the
project-system-relayering
branch
from
81b2e6e
to
0044010
Compare
jasonmalinowski
commented
Dec 6, 2022
|
|
||
| namespace Microsoft.CodeAnalysis.Workspaces.ProjectSystem | ||
| { | ||
| // TODO: see if we can get rid of this interface by appropriately rewriting HostDiagnosticUpdateSource to live at the workspaces layer. |
There was a problem hiding this comment.
Yes, I realize I'm introducing an interface that has a TODO to get rid of it. There's a lot of other tangles for that which I don't want to fight at the moment.
dibarbet
reviewed
Dec 6, 2022
| /// An interface implemented by hosts to provide the host-level analyzers; for example in Visual Studio for Windows this | ||
| /// is where we'll fetch VSIX-defined analyzers. | ||
| /// </summary> | ||
| internal interface IHostDiagnosticAnalyzerProvider |
There was a problem hiding this comment.
do we need the factory as an interface?
https://sourceroslyn.io/#Microsoft.VisualStudio.LanguageServices/Diagnostics/VisualStudioDiagnosticAnalyzerProvider.Factory.cs,19
Or what is the way we provide the implementation?
There was a problem hiding this comment.
It might be a MEF part, but just grabbed and passed in directly to the project type.
dibarbet
approved these changes
Dec 6, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces some more interfaces.