Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract a few more interfaces from the VS layer project system #65799

Merged
merged 6 commits into from
Dec 6, 2022
Merged

Extract a few more interfaces from the VS layer project system #65799

merged 6 commits into from
Dec 6, 2022

Commits on Dec 6, 2022

  1. Only add a watched directory if we're on Windows

    @jasonmalinowski
    jasonmalinowski committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    58f0f17 View commit details
    Browse the repository at this point in the history

  2. Introduce IHostDiagnosticAnalyzerProvider to abstract getting host VS… 

    …IXes
    @jasonmalinowski
    jasonmalinowski committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    37c14e5 View commit details
    Browse the repository at this point in the history

  3. Introduce an interface around HostDiagnosticUpdateSource 

    This is what we report analyzer load issues through; this probably needs
a larger refactoring because:

1. I'm not sure why we have both the base type and derived type, since
   there's only one inheriting from the base type.
2. Much of this is used for analyzer dependency conflict checking,
   which is perhaps of limited use in the first place.
    @jasonmalinowski
    jasonmalinowski committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    c0a9aa5 View commit details
    Browse the repository at this point in the history

  4. Delete unused local code

    @jasonmalinowski
    jasonmalinowski committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    46a8d79 View commit details
    Browse the repository at this point in the history

  5. Remove unused field

    @jasonmalinowski
    jasonmalinowski committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    801e71d View commit details
    Browse the repository at this point in the history

  6. Remove unused usings

    @jasonmalinowski
    jasonmalinowski committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    0044010 View commit details
    Browse the repository at this point in the history