Semantic snippets: Add inline statement snippets #67819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ghost
added
the
Community
|
Is there a documentation / a blog post regarding semantic snippets in general? Sorry to asking here. I'm just curious. |
|
The original proposal is #56541. A few things changed (e.g. as far as I know there is no intend to make snippet text as descriptions, e.g. |
|
Can I get a review here? @akhera99 I cannot just add you to review list since I am an external contributor, so tagging you explicitely. |
akhera99
approved these changes
May 1, 2023
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
May 2, 2023
* upstream/main: (2060 commits) implement code folding for anonymous objects Cleanup/perf in creating member maps. (dotnet#67997) Address feedback, clean the use of ILegacyGlobalOptionsWorkspaceService Update Publish.json Semantic snippets: Add inline statement snippets (dotnet#67819) Update VSSDK Build tools version Update doc comment Address feedback Move declaration near reference Address feedback Avoid stack overflow due to deep recursion on long chain of calls. (dotnet#67913) Check ILegacyGlobalOptionsWorkspaceService is null test scout queue add test update editor "Where" clause typo fix (dotnet#68002) Use `Keyword` helper method instead of hardcoding keyword help terms Move the SyntaxTree and SemanticModel action based analyzers to respect context.FilterSpan EnC refactoring: Align wrappers with contracts better (dotnet#67967) Include EA.RazorCompiler in source build (dotnet#67996) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit: added all abstractions for inline statement snippets. Made
ifandwhilestatements inlineSecond commit: while working I noticed that all current snippets produce a single
TextChange, so abstracted that in a separate classThird commit: made
foreachsnippet inline as well. It required a little change in the abstraction frameork made in commit 1Closes: #60628
Demo:
