Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental Generators documentation fix #68002

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Incremental Generators documentation fix #68002

merged 1 commit into from
Apr 28, 2023

Conversation

eprupet
Copy link
Contributor

@eprupet eprupet commented Apr 27, 2023 •
edited
Loading

"Where" clause typo fix

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 27, 2023
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Apr 27, 2023
@eprupet
Copy link
Contributor Author

eprupet commented Apr 27, 2023

@dotnet-policy-service agree

@eprupet eprupet changed the title "Where" clause typo fix Incremental Generators documentation "Where" clause typo fix Apr 27, 2023
@eprupet eprupet changed the title Incremental Generators documentation "Where" clause typo fix Incremental Generators documentation fix Apr 27, 2023
jcouv
jcouv approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv added Documentation and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 28, 2023
@jcouv
Copy link
Member

jcouv commented Apr 28, 2023

FYI @chsienki I'm merging with a single review since doc-only change.

@jcouv jcouv merged commit ae24476 into dotnet:main Apr 28, 2023
@ghost ghost added this to the Next milestone Apr 28, 2023
333fred added a commit to 333fred/roslyn that referenced this pull request May 2, 2023
@333fred
Merge remote-tracking branch 'upstream/main' into vb-required
610d5f4 
* upstream/main: (2060 commits)
  implement code folding for anonymous objects
  Cleanup/perf in creating member maps. (dotnet#67997)
  Address feedback, clean the use of ILegacyGlobalOptionsWorkspaceService
  Update Publish.json
  Semantic snippets: Add inline statement snippets (dotnet#67819)
  Update VSSDK Build tools version
  Update doc comment
  Address feedback
  Move declaration near reference
  Address feedback
  Avoid stack overflow due to deep recursion on long chain of calls. (dotnet#67913)
  Check ILegacyGlobalOptionsWorkspaceService is null
  test scout queue
  add test
  update editor
  "Where" clause typo fix (dotnet#68002)
  Use `Keyword` helper method instead of hardcoding keyword help terms
  Move the SyntaxTree and SemanticModel action based analyzers to respect context.FilterSpan
  EnC refactoring: Align wrappers with contracts better (dotnet#67967)
  Include EA.RazorCompiler in source build (dotnet#67996)
  ...
@allisonchou allisonchou mentioned this pull request May 2, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

Assignees
No one assigned
Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. Documentation
Projects
None yet
Milestone
17.7 P2
Development

Successfully merging this pull request may close these issues.
3 participants
@eprupet @jcouv @Cosifne