Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 17.0-vs-deps into 17.2 #67920

Merged
merged 16 commits into from
Apr 21, 2023

Conversation

dibarbet
Copy link
Member

No description provided.

dibarbet and others added 16 commits May 26, 2022 10:49
…411.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.22524.5 -> To Version 7.0.0-beta.23211.2
… darc-release/dev17.0-vs-deps-aa698329-9cc5-493d-a240-5ac8bfeee6c1
* Don't overwrite binary logs

Several of our legs were calling `build.ps1 -binaryLog` in a row and
that re-uses the binary log file name which causes an overwrite. This
change allows us to specify the name and adds a warning if we do
accidentally overwrite in the future.

* enable trace for diff issue

* Work around NuGet static graph restore bug

NuGet/Home#12373
* Don't overwrite binary logs in CI

This will make it an error whenever we overwrite a binary log during CI.
Doing so means we've lost one of our main tools for investigating build
failures. Turning this into an error so we don't make the mistake
again.

* actually fail

* fixup
* Disable static restore in more locations

* Run compilers CI when build scripts change

* Include compiler generators in compilers code change check

* Remove separate restore in bootstrap build
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 21, 2023
@dibarbet dibarbet marked this pull request as ready for review April 21, 2023 22:46
@dibarbet dibarbet requested a review from a team as a code owner April 21, 2023 22:46
@dibarbet dibarbet merged commit 28905bb into dotnet:release/dev17.2 Apr 21, 2023
@dibarbet dibarbet deleted the dev/dibarbet/merge_17_0 branch April 21, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants