Modify (Large/Source)Text.ParseLineStart to specify an initial capacity for line count #73701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per Tomas, the enc analyzer can be trivially changed for this support. Also, smal change where I missed one location in method extractor analyzer that needed a change
…ty for line count Noticed this in a Find All References profile, the LargeText.ParseLineStarts was showing as 6.2% of allocations and SourceText.ParseLineStarts was 0.4%. With this change, these reduced to 4.7% and 0.2% respectively.
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
CyrusNajmabadi
approved these changes
May 24, 2024
|
@dotnet/roslyn-compiler ptal |
|
@dotnet/roslyn-compiler -- ptal |
1 similar comment
|
@dotnet/roslyn-compiler -- ptal |
jjonescz
approved these changes
May 29, 2024
| @@ -238,7 +238,9 @@ private SegmentedList<int> ParseLineStarts() | |||
| var position = 0; | |||
| var index = 0; | |||
| var lastCr = -1; | |||
| var list = new SegmentedList<int>(); | |||
| // Initial line capacity estimated at 64 chars / line. This values was obtained by | |||
There was a problem hiding this comment.
Suggested change
| // Initial line capacity estimated at 64 chars / line. This values was obtained by | |
| // Initial line capacity estimated at 64 chars / line. This value was obtained by |
| @@ -1049,7 +1049,9 @@ private SegmentedList<int> ParseLineStarts() | |||
| return [0]; | |||
| } | |||
|
|
|||
| var lineStarts = new SegmentedList<int>() | |||
| // Initial line capacity estimated at 64 chars / line. This values was obtained by | |||
There was a problem hiding this comment.
Suggested change
| // Initial line capacity estimated at 64 chars / line. This values was obtained by | |
| // Initial line capacity estimated at 64 chars / line. This value was obtained by |
|
@dotnet/roslyn-compiler -- ptal |
jaredpar
approved these changes
May 30, 2024
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this in a Find All References profile, the LargeText.ParseLineStarts was showing as 6.2% of allocations and SourceText.ParseLineStarts was 0.4%.
With this change, these reduced to 4.7% and 0.2% respectively.
*** before ***
and
*** after ***
and