-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify (Large/Source)Text.ParseLineStart to specify an initial capacity for line count #73701
Merged
ToddGrun
merged 5 commits into
dotnet:main
from
ToddGrun:dev/toddgrun/ParseLineStartsAllocations
May 30, 2024
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
27b48c5
Final editor side changes for "allow ref struct" support
ToddGrun 73bb9cf
Modify (Large/Source)Text.ParseLineStart to specify an initial capaci…
ToddGrun e75dcb9
Merge branch 'dotnet:main' into dev/toddgrun/ParseLineStartsAllocations
ToddGrun 5759682
Add comment indicating how magic number was determined.
ToddGrun 0fe95fb
fix typo
ToddGrun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -1049,7 +1049,9 @@ private SegmentedList<int> ParseLineStarts() | |||||
return [0]; | ||||||
} | ||||||
|
||||||
var lineStarts = new SegmentedList<int>() | ||||||
// Initial line capacity estimated at 64 chars / line. This values was obtained by | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
// looking at ratios in large files in the roslyn repo. | ||||||
var lineStarts = new SegmentedList<int>(Length / 64) | ||||||
{ | ||||||
0 // there is always the first line | ||||||
}; | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.