[QUIC] Fix TestConnect #49660
Merged
[QUIC] Fix TestConnect #49660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsContributes to #49157
|
ManickaP
approved these changes
Mar 16, 2021
| @@ -82,6 +82,7 @@ public async Task SetListenerTimeoutWorksWithSmallTimeout() | |||
| await Assert.ThrowsAsync<QuicOperationAbortedException>(async () => await serverConnection.AcceptStreamAsync().TimeoutAfter(100000)); | |||
| } | |||
|
|
|||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/49157")] | |||
There was a problem hiding this comment.
We're not running these in CI AFAIK so the failures are not blocking any PRs. This will disable them for our local runs, is that what you're goal here is?
There was a problem hiding this comment.
Yep, it is for us to have a clean local test run, since we are to start adding new changes. So if some new failures appear, we will know it was because of our changes
|
Failures are unrelated. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #49157