Skip to content

Commit

Permalink
evaluate-default-paths.yml: Add paths for wasi (#81817)
Browse files Browse the repository at this point in the history
* evaluate-default-paths.yml: Add paths for wasi

.. and exclude wasm specific paths from coreclr.

* disable runtime-wasm-optional automatic trigger for PRs

* CI: skip debugger tests on runtime-wasm if they run on runtime pipeline

.. too.

* fix condition

* address review feedback from @kg

* Fix yml issue

Using `Was?Runner*` failed to validate on azdo with:

`/eng/pipelines/common/evaluate-default-paths.yml (Line: 10, Col: 24): While parsing a flow sequence, did not find expected ',' or ']'.`

* fix syntax error in yml
  • Loading branch information
radical committed Feb 9, 2023
1 parent 232fbce commit 765e3db
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 6 deletions.
8 changes: 7 additions & 1 deletion eng/pipelines/common/evaluate-default-paths.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,14 @@ parameters:
_const_paths:
_wasm_specific_only: [
eng/testing/ProvisioningVersions.props
eng/testing/WasmRunner*
eng/testing/WasiRunner*
eng/testing/scenarios/BuildWasmAppsJobsList.txt
eng/testing/tests.wasm.targets
eng/testing/tests.browser.targets
eng/testing/tests.was*.targets
eng/testing/was*provisioning.targets
src/libraries/sendtohelix-wasm.targets
src/libraries/sendtohelix-wasi.targets
src/mono/mono/**/*wasm*
src/mono/nuget/Microsoft.NET.Runtime.WebAssembly.Sdk/*
src/mono/nuget/Microsoft.NET.Runtime.wasm.Sample.Mono/*
Expand Down Expand Up @@ -70,6 +75,7 @@ jobs:
- eng/pipelines/installer/*
- eng/pipelines/mono/*
- eng/pipelines/libraries/*
- ${{ parameters._const_paths._wasm_specific_only }}
- ${{ parameters._const_paths._wasm_pipelines }}
- ${{ parameters._const_paths._always_exclude }}

Expand Down
7 changes: 6 additions & 1 deletion eng/pipelines/common/templates/wasm-debugger-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ parameters:
isWasmOnlyBuild: false
browser: 'chrome'
shouldContinueOnError: false
runOnlyOnWasmOnlyPipelines: false
extraBuildArgs: ''
nameSuffix: ''
platforms: []
Expand All @@ -23,6 +24,8 @@ jobs:
# map dependencies variables to local variables
- name: alwaysRunVar
value: ${{ parameters.alwaysRun }}
- name: runOnlyOnWasmPipelinesVar
value: ${{ parameters.runOnlyOnWasmOnlyPipelines }}
- name: shouldRunOnDefaultPipelines
value: $[
or(
Expand All @@ -47,7 +50,9 @@ jobs:
condition: >-
or(
eq(variables['alwaysRunVar'], true),
eq(variables['isDefaultPipeline'], variables['shouldRunOnDefaultPipelines']))
and(
eq(variables['isDefaultPipeline'], variables['shouldRunOnDefaultPipelines']),
ne(variables['runOnlyOnWasmPipelinesVar'], 'true')))
extraStepsTemplate: /eng/pipelines/libraries/helix.yml
extraStepsParameters:
creator: dotnet-bot
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ jobs:
alwaysRun: ${{ parameters.isWasmOnlyBuild }}
isExtraPlatformsBuild: ${{ parameters.isExtraPlatformsBuild }}
isWasmOnlyBuild: ${{ parameters.isWasmOnlyBuild }}
runOnlyOnWasmOnlyPipelines: true

# Disable for now
#- template: /eng/pipelines/coreclr/perf-wasm-jobs.yml
Expand Down
5 changes: 1 addition & 4 deletions eng/pipelines/runtime-wasm-optional.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
# This is a wrapper yml for `extra-platforms/runtime-extra-platforms-wasm.yml`, which
# has all the wasm jobs. This file is essentially so we can have point
# the pipeline in azdo UI to this, and thus avoid any scheduled triggers

trigger: none
pr: none

variables:
- template: /eng/pipelines/common/variables.yml
Expand Down

0 comments on commit 765e3db

Please sign in to comment.