Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluate-default-paths.yml: Add paths for wasi #81817

Merged
merged 8 commits into from
Feb 9, 2023

Conversation

radical
Copy link
Member

@radical radical commented Feb 8, 2023

.. and exclude wasm specific paths from coreclr.

  • This will ensure that wasm specific changes don't trigger all the coreclr, and then mono builds
  • And changes in new wasi specific files will trigger wasm jobs
  • And don't trigger wasm debugger tests on manual pipelines if they are run on runtime pipeline

.. and exclude wasm specific paths from coreclr.
@ghost
Copy link

ghost commented Feb 8, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

.. and exclude wasm specific paths from coreclr.

  • This will ensure that wasm specific changes don't trigger all the coreclr, and then mono builds
  • And changes in new wasi specific files will trigger wasm jobs
Author: radical
Assignees: -
Labels:

arch-wasm, area-Infrastructure-mono

Milestone: -

@@ -7,9 +7,13 @@ parameters:
_const_paths:
_wasm_specific_only: [
eng/testing/ProvisioningVersions.props
eng/testing/Was*Runner*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(m|i) instead of *?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or use ? to be clear that it's one character

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the caveat that i don't know what kind of glob/regex syntax is being used here :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. these are used with git diff, and follow git pathspec.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmph azdo didn't like ?: /eng/pipelines/common/evaluate-default-paths.yml (Line: 10, Col: 24): While parsing a flow sequence, did not find expected ',' or ']'.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took the easy way out with WasmRunner*, and WasiRunner.

@@ -4,6 +4,7 @@ parameters:
isWasmOnlyBuild: false
browser: 'chrome'
shouldContinueOnError: false
runOnlyOnWasmPipelines: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused as to why this would want to run on non-wasm pipelines. Are the wasm debugger tests not a wasm pipeline?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should really be named runOnlyOnWasmOnlyPipelines or such!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it should run only on runtime-wasm* pipelines which have only wasm builds, and are run manually.

Using `Was?Runner*` failed to validate on azdo with:

`/eng/pipelines/common/evaluate-default-paths.yml (Line: 10, Col: 24): While parsing a flow sequence, did not find expected ',' or ']'.`
@radical
Copy link
Member Author

radical commented Feb 9, 2023

This is a CI only change, and the failures are unrelated.

@radical radical merged commit 765e3db into dotnet:main Feb 9, 2023
@radical radical deleted the ci-more-fixes branch February 9, 2023 01:20
@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants