Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.NET.Sdk.IL nuget packages is broken #49135

Closed
ViktorHofer opened this issue Mar 4, 2021 · 5 comments · Fixed by #96069
Closed

Microsoft.NET.Sdk.IL nuget packages is broken #49135

ViktorHofer opened this issue Mar 4, 2021 · 5 comments · Fixed by #96069

Comments

@ViktorHofer
Copy link
Member

The latest available version of the Microsoft.NET.Sdk.IL package on nuget.org is broken as it tries to resolve runtime ilasm/ildasm packages with a version of 6.0.0 which doesn't exist until we ship.

There are different options how to fix this:

  • Generate the targets file which contains the hardcoded version dynamically and embed the product version in it. We do this in couple other places and it's fairly easy to implement.
  • Change how the Sdk.IL meta package references dependencies. Today the SDK is resolved via the nuget sdk resolver in a first restore phase and then latter in the overall nuget restore phase the dependent RID specific IL package is downloaded as it's listed as a PackageReference by the IL SDK. There are alternatives to that which could be considered i.e. FrameworkPackages or merging the runtime packages which only contain the native ilasm/ildasm into the IL SDK meta package.

cc @trylek @hoyosjs @ericstj

@ghost
Copy link

ghost commented Mar 4, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

The latest available version of the Microsoft.NET.Sdk.IL package on nuget.org is broken as it tries to resolve runtime ilasm/ildasm packages with a version of 6.0.0 which doesn't exist until we ship.

There are different options how to fix this:

  • Generate the targets file which contains the hardcoded version dynamically and embed the product version in it. We do this in couple other places and it's fairly easy to implement.
  • Change how the Sdk.IL meta package references dependencies. Today the SDK is resolved via the nuget sdk resolver in a first restore phase and then latter in the overall nuget restore phase the dependent RID specific IL package is downloaded as it's listed as a PackageReference by the IL SDK. There are alternatives to that which could be considered i.e. FrameworkPackages or merging the runtime packages which only contain the native ilasm/ildasm into the IL SDK meta package.

cc @trylek @hoyosjs @ericstj

Author: ViktorHofer
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 4, 2021
@ViktorHofer ViktorHofer removed the untriaged New issue has not been triaged by the area owner label Mar 5, 2021
@ViktorHofer ViktorHofer modified the milestones: 6.0.0, Future Mar 5, 2021
@ViktorHofer ViktorHofer modified the milestones: Future, 6.0.0 Mar 5, 2021
@ViktorHofer
Copy link
Member Author

TODO: Discuss if we wanna continue shipping the package on nuget.org.

@iskiselev
Copy link

This package is very useful for implementing low-level tests for profilers.

@JulieLeeMSFT
Copy link
Member

CC @briansull PTAL.

@JulieLeeMSFT
Copy link
Member

@infra team, please decide on the best option between the two and implement it. JIT team does not have preference.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Dec 15, 2023
akoeplinger added a commit to akoeplinger/runtime that referenced this issue Dec 15, 2023
We were still hardcoding version 6.0.0 of ILAsm in the targets, fix it by using a template and injecting the PackageVersion.

Fixes dotnet#49135
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Dec 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants