Fix hardcoded ILAsm package version in Microsoft.NET.SDK.IL #96069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsWe were still hardcoding version 6.0.0 of ILAsm in the targets, fix it by using a template and injecting the ProductVersion. Fixes #49135
|
akoeplinger
removed
the
needs-area-label
ViktorHofer
reviewed
Dec 15, 2023
src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Microsoft.NET.Sdk.IL.pkgproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Dec 15, 2023
src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Microsoft.NET.Sdk.IL.pkgproj
Outdated
Show resolved
Hide resolved
akoeplinger
force-pushed
the
fix-ilsdk
branch
from
b9e7744
to
9390458
Compare
We were still hardcoding version 6.0.0 of ILAsm in the targets, fix it by using a template and injecting the PackageVersion. Fixes dotnet#49135
akoeplinger
force-pushed
the
fix-ilsdk
branch
from
9390458
to
fe8aa9c
Compare
ViktorHofer
approved these changes
Dec 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were still hardcoding version 6.0.0 of ILAsm in the targets, fix it by using a template and injecting the ProductVersion.
Fixes #49135