-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failure System.Reflection.Tests.ModuleTests.GetMethods #50831
Comments
Looks like this test was added with #50076 |
@erafalovsky would you be interested in fixing this? Maybe we can just sort the sequence before comparing. I forgot that the reflection stack doesn't guarantee ordering of members. From the docs:
|
Failed again in runtime-coreclr libraries-jitstress 20210428.1 Failed test:
Error message:
|
Failed again in runtime-coreclr libraries-jitstress 20210512.1 Failed test:
Error message:
|
Failed again in runtime-coreclr libraries-jitstress2-jitstressregs 20210605.1 Failed test:
Error message:
|
Another failure: net6.0-windows-Release-arm64-CoreCLR_checked-jitstress2_jitstressregs1:
|
The proposed fix is trivial: sort the returned methods and compare:
FWIW the tests in System.Text.Json also sort in a similar fashion - the properties for a JSON object produced by serializing a CLR object are typically sorted by property name due to nondeterminstic reflection ordering (i.e. the JSON is serialized in the order of the reflected properties). |
Run: runtime-coreclr libraries-jitstress 20210406.1
Failed test:
Error message:
The text was updated successfully, but these errors were encountered: