Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable failing System.Reflection.Tests.ModuleTests.GetMethods #54564

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Disable failing System.Reflection.Tests.ModuleTests.GetMethods #54564

merged 1 commit into from
Jun 23, 2021

Conversation

BruceForstall
Copy link
Member

Tracking: #50831

@stephentoub
Copy link
Member

@BruceForstall, has this only ever failed in stress runs? If yes, can we only disable it for such runs?

@BruceForstall
Copy link
Member Author

It does look like it's only failed in libraries-jitstress modes, but one failure was in "no tiered compilation", and I'm not sure that counts as "stress" to the excluder code. Maybe switch to [SkipOnCoreClr...?

@BruceForstall
Copy link
Member Author

fwiw, we really need a comprehensive "how to disable a test anywhere in the tree under any set of conditions" document...

@stephentoub
Copy link
Member

Maybe switch to [SkipOnCoreClr...?

That's what I was thinking, but if it might be failing elsewhere as well, we can stick with the "disable everywhere" for now.

@BruceForstall
Copy link
Member Author

release coreclr windows x86 Debug failure:

   System.Net.Http.WinHttpHandler.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler_Asynchrony_Http2_Test.ResponseHeadersRead_SynchronizationContextNotUsedByHandler', Elapsed: 00:02:10
   System.Net.Http.WinHttpHandler.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler_Asynchrony_Http2_Test.ResponseHeadersRead_SynchronizationContextNotUsedByHandler', Elapsed: 00:04:22
   System.Net.Http.WinHttpHandler.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler_Asynchrony_Http2_Test.ResponseHeadersRead_SynchronizationContextNotUsedByHandler', Elapsed: 00:06:22
   System.Net.Http.WinHttpHandler.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler_Asynchrony_Http2_Test.ResponseHeadersRead_SynchronizationContextNotUsedByHandler', Elapsed: 00:08:22
   System.Net.Http.WinHttpHandler.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler_Asynchrony_Http2_Test.ResponseHeadersRead_SynchronizationContextNotUsedByHandler', Elapsed: 00:10:22
   System.Net.Http.WinHttpHandler.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.PlatformHandler_HttpClientHandler_Asynchrony_Http2_Test.ResponseHeadersRead_SynchronizationContextNotUsedByHandler', Elapsed: 00:12:22
['System.Net.Http.WinHttpHandler.Functional.Tests' WORK ITEM LOG TRUNCATED: Command timed out, and was killed]

@BruceForstall BruceForstall merged commit f3556b3 into dotnet:main Jun 23, 2021
@BruceForstall BruceForstall deleted the DisableModuleTestsFor50831 branch June 23, 2021 04:42
thaystg added a commit to thaystg/runtime that referenced this pull request Jun 23, 2021
@thaystg
Merge remote-tracking branch 'origin/main' into thays_fix_exception_i…
ae2a17c 
…nitial_config

* origin/main: (362 commits)
  [wasm][debugger] Reuse debugger-agent on wasm debugger (dotnet#52300)
  Put Crossgen2 in sync with dotnet#54235 (dotnet#54438)
  Move System.Object serialization to ObjectConverter (dotnet#54436)
  Move setting fHasVirtualStaticMethods out of sanity check section (dotnet#54574)
  [wasm] Compile .bc->.o in parallel, before passing to the linker (dotnet#54053)
  Change PathInternal.IsCaseSensitive to a constant (dotnet#54340)
  Make mono_polling_required a public symbol (dotnet#54592)
  Respect EventSource::IsSupported setting in more codepaths (dotnet#51977)
  Root ComActivator for hosting (dotnet#54524)
  Add ILLink annotations to S.D.Common related to DbConnectionStringBuilder (dotnet#54280)
  Fix finalizer issue with regions (dotnet#54550)
  Add support for multi-arch install locations (dotnet#53763)
  Update library testing docs page to reduce confusion (dotnet#54324)
  [FileStream] handle UNC and device paths (dotnet#54483)
  Update NetAnalyzers version (dotnet#54511)
  Added runtime dependency to fix the intermittent test failures (dotnet#54587)
  Disable failing System.Reflection.Tests.ModuleTests.GetMethods (dotnet#54564)
  [wasm] Move AOT builds from `runtime-staging` to `runtime` (dotnet#54577)
  Keep obj node for ArrayIndex. (dotnet#54584)
  Disable another failing MemoryCache test (dotnet#54578)
  ...
@ghost ghost locked as resolved and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky

Assignees
No one assigned
Labels
area-System.Reflection
Projects
No open projects
Triage POD for Reflection, META, etc.
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BruceForstall @stephentoub