Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.IO.Pipelines.Tests Fails on Android #50927

Closed
mdh1418 opened this issue Apr 8, 2021 · 3 comments · Fixed by #56635
Closed

System.IO.Pipelines.Tests Fails on Android #50927

mdh1418 opened this issue Apr 8, 2021 · 3 comments · Fixed by #56635
Assignees
@mdh1418
Labels
area-System.IO.Pipelines os-android
Milestone
7.0.0

Comments

@mdh1418
Copy link
Member

mdh1418 commented Apr 8, 2021

System.IO.Pipelines.Tests
System.IO.Pipelines.Tests.FlushAsyncTests.DoubleFlushAsyncThrows
System.IO.Pipelines.Tests.PipelineReaderWriterFacts.AdvanceAfterCompleteThrows
System.IO.Pipelines.Tests.PipelineReaderWriterFacts.DoubleAsyncReadThrows
System.IO.Pipelines.Tests.PipelineReaderWriterFacts.AdvanceWithoutReadThrows
System.IO.Pipelines.Tests.FlushAsyncCompletionTests.AwaitingFlushAsyncAwaitableTwiceCompletesReaderWithException
System.IO.Pipelines.Tests.ReadAsyncCompletionTests.AwaitingReadAsyncAwaitableTwiceCompletesWriterWithException

System.IO.Pipelines.Tests.dll   Failed: 6

Test collection for System.IO.Pipelines.Tests.FlushAsyncTests
System.IO.Pipelines.Tests.FlushAsyncTests.DoubleFlushAsyncThrows
    Assert.Equal() Failure\n                    ↓ (pos 10)\nExpected: Concurrent reads or writes are not supported.\nActual:   ConcurrentOperationsNotSupported\n                    ↑ (pos 10)

Test collection for System.IO.Pipelines.Tests.PipelineReaderWriterFacts
System.IO.Pipelines.Tests.PipelineReaderWriterFacts.AdvanceAfterCompleteThrows
    Assert.Equal() Failure\n                 ↓ (pos 7)\nExpected: Reading is not allowed after reader was complete···\nActual:   ReadingAfterCompleted\n                 ↑ (pos 7)
System.IO.Pipelines.Tests.PipelineReaderWriterFacts.DoubleAsyncReadThrows
    Assert.Equal() Failure\n                    ↓ (pos 10)\nExpected: Concurrent reads or writes are not supported.\nActual:   ConcurrentOperationsNotSupported\n                    ↑ (pos 10)
System.IO.Pipelines.Tests.PipelineReaderWriterFacts.AdvanceWithoutReadThrows
    Assert.Equal() Failure\n            ↓ (pos 2)\nExpected: No reading operation to complete.\nActual:   NoReadingOperationToComplete\n            ↑ (pos 2)

Test collection for System.IO.Pipelines.Tests.FlushAsyncCompletionTests
System.IO.Pipelines.Tests.FlushAsyncCompletionTests.AwaitingFlushAsyncAwaitableTwiceCompletesReaderWithException
    Assert.Equal() Failure\n                    ↓ (pos 10)\nExpected: Concurrent reads or writes are not supported.\nActual:   ConcurrentOperationsNotSupported\n                    ↑ (pos 10)

Test collection for System.IO.Pipelines.Tests.ReadAsyncCompletionTests
System.IO.Pipelines.Tests.ReadAsyncCompletionTests.AwaitingReadAsyncAwaitableTwiceCompletesWriterWithException
    Assert.Equal() Failure\n                    ↓ (pos 10)\nExpected: Concurrent reads or writes are not supported.\nActual:   ConcurrentOperationsNotSupported\n                    ↑ (pos 10)
@mdh1418 mdh1418 added this to the 6.0.0 milestone Apr 8, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.IO.Pipelines untriaged New issue has not been triaged by the area owner labels Apr 8, 2021
@davidfowl
Copy link
Member

Wow, what's hapenning on android

@BrennanConroy
Copy link
Member

Looks like android doesn't implement exception.Message properly?

@BrennanConroy BrennanConroy removed the untriaged New issue has not been triaged by the area owner label Apr 9, 2021
@steveisok
Copy link
Member

To clear up confusion, a while ago we had UseSystemResourceKeys set to false by mistake for our test runs. It created a lot of false failures. This issue being one of them.

@mdh1418 you can re-enable these tests as they will pass.

@steveisok steveisok modified the milestones: 6.0.0, 7.0.0 Jul 30, 2021
@mdh1418 mdh1418 mentioned this issue Jul 30, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 30, 2021
steveisok pushed a commit that referenced this issue Jul 30, 2021
@mdh1418
[libraries][Android] Reenable tests failing from feature switches bei…
dcacebb 
…ng improperly set (#56635)

Fixes #50576
Fixes #50881
Fixes #50916
Fixes #50917
Fixes #50918
Fixes #50919
Fixes #50927
Fixes #50928
Fixes #50944
Fixes #50945
Fixes #50946
Fixes #50947
Fixes #50948
Fixes #50999

When setting up functional tests for mobile, the feature switches being used for the tests were misplaced in a broader project, affecting the library tests and causing failures. After moving the feature switches to the scope of functional tests as done in #53253, these test suites no longer fail and can be re-enabled.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 30, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mdh1418 mdh1418

Labels
area-System.IO.Pipelines os-android
Projects
None yet
Milestone
7.0.0
4 participants
@davidfowl @steveisok @BrennanConroy @mdh1418