Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Xml.Linq.xNodeBuilder.Tests Fails on Android #50944

Closed
Tracked by #64602
mdh1418 opened this issue Apr 8, 2021 · 2 comments · Fixed by #56635
Closed
Tracked by #64602

System.Xml.Linq.xNodeBuilder.Tests Fails on Android #50944

mdh1418 opened this issue Apr 8, 2021 · 2 comments · Fixed by #56635
Assignees
@mdh1418
Labels
area-System.Xml os-android
Milestone
7.0.0

Comments

@mdh1418
Copy link
Member

mdh1418 commented Apr 8, 2021

System.Xml.Linq.xNodeBuilder.Tests
CoreXml.Test.XLinq.XNodeBuilderFunctionalTests+XNodeBuilderTests+TCComment.WriteCommentWithDoubleHyphensInValue
CoreXml.Test.XLinq.XNodeBuilderFunctionalTests+XNodeBuilderTests+TCCData.WriteCDataWithTwoClosingBrackets_5
CoreXml.Test.XLinq.XNodeBuilderFunctionalTests+XNodeBuilderTests+TCPI.IncludePIEndTagAsPartOfTextValue

System.Xml.Linq.xNodeBuilder.Tests.dll   Failed: 3

Test collection for CoreXml.Test.XLinq.XNodeBuilderFunctionalTests+XNodeBuilderTests+TCComment
CoreXml.Test.XLinq.XNodeBuilderFunctionalTests+XNodeBuilderTests+TCComment.WriteCommentWithDoubleHyphensInValue
    Assert.Matches() Failure:\nRegex: \\bXML\\b\nValue: Xml_InvalidCommentChars

Test collection for CoreXml.Test.XLinq.XNodeBuilderFunctionalTests+XNodeBuilderTests+TCCData
CoreXml.Test.XLinq.XNodeBuilderFunctionalTests+XNodeBuilderTests+TCCData.WriteCDataWithTwoClosingBrackets_5
    Assert.Matches() Failure:\nRegex: [\\p{Pi}\\p{Po}]]]>[\\p{Pf}\\p{Po}]\nValue: Xml_InvalidCDataChars

Test collection for CoreXml.Test.XLinq.XNodeBuilderFunctionalTests+XNodeBuilderTests+TCPI
CoreXml.Test.XLinq.XNodeBuilderFunctionalTests+XNodeBuilderTests+TCPI.IncludePIEndTagAsPartOfTextValue
    Assert.Matches() Failure:\nRegex: [\\p{Pi}\\p{Po}]\\?>[\\p{Pf}\\p{Po}]\nValue: Xml_InvalidPiChars
@mdh1418 mdh1418 added this to the 6.0.0 milestone Apr 8, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Xml untriaged New issue has not been triaged by the area owner labels Apr 8, 2021
@ghost
Copy link

ghost commented Apr 8, 2021

Tagging subscribers to this area: @buyaa-n, @krwq
See info in area-owners.md if you want to be subscribed.

Issue Details

System.Xml.Linq.xNodeBuilder.Tests
CoreXml.Test.XLinq.XNodeBuilderFunctionalTests+XNodeBuilderTests+TCComment.WriteCommentWithDoubleHyphensInValue
CoreXml.Test.XLinq.XNodeBuilderFunctionalTests+XNodeBuilderTests+TCCData.WriteCDataWithTwoClosingBrackets_5
CoreXml.Test.XLinq.XNodeBuilderFunctionalTests+XNodeBuilderTests+TCPI.IncludePIEndTagAsPartOfTextValue

System.Xml.Linq.xNodeBuilder.Tests.dll   Failed: 3

Test collection for CoreXml.Test.XLinq.XNodeBuilderFunctionalTests+XNodeBuilderTests+TCComment
CoreXml.Test.XLinq.XNodeBuilderFunctionalTests+XNodeBuilderTests+TCComment.WriteCommentWithDoubleHyphensInValue
    Assert.Matches() Failure:\nRegex: \\bXML\\b\nValue: Xml_InvalidCommentChars

Test collection for CoreXml.Test.XLinq.XNodeBuilderFunctionalTests+XNodeBuilderTests+TCCData
CoreXml.Test.XLinq.XNodeBuilderFunctionalTests+XNodeBuilderTests+TCCData.WriteCDataWithTwoClosingBrackets_5
    Assert.Matches() Failure:\nRegex: [\\p{Pi}\\p{Po}]]]>[\\p{Pf}\\p{Po}]\nValue: Xml_InvalidCDataChars

Test collection for CoreXml.Test.XLinq.XNodeBuilderFunctionalTests+XNodeBuilderTests+TCPI
CoreXml.Test.XLinq.XNodeBuilderFunctionalTests+XNodeBuilderTests+TCPI.IncludePIEndTagAsPartOfTextValue
    Assert.Matches() Failure:\nRegex: [\\p{Pi}\\p{Po}]\\?>[\\p{Pf}\\p{Po}]\nValue: Xml_InvalidPiChars

<table>
  <tr>
    <th align="left">Author:</th>
    <td>mdh1418</td>
  </tr>
  <tr>
    <th align="left">Assignees:</th>
    <td>-</td>
  </tr>
  <tr>
    <th align="left">Labels:</th>
    <td>

`area-System.Xml`, `os-android`, `untriaged`

</td>
  </tr>
  <tr>
    <th align="left">Milestone:</th>
    <td>6.0.0</td>
  </tr>
</table>
</details>

@buyaa-n buyaa-n removed the untriaged New issue has not been triaged by the area owner label Apr 12, 2021
@steveisok
Copy link
Member

@mdh1418 These tests pass on Android and can be re-enabled.

@steveisok steveisok modified the milestones: 6.0.0, 7.0.0 Jul 30, 2021
@mdh1418 mdh1418 mentioned this issue Jul 30, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 30, 2021
steveisok pushed a commit that referenced this issue Jul 30, 2021
@mdh1418
[libraries][Android] Reenable tests failing from feature switches bei…
dcacebb 
…ng improperly set (#56635)

Fixes #50576
Fixes #50881
Fixes #50916
Fixes #50917
Fixes #50918
Fixes #50919
Fixes #50927
Fixes #50928
Fixes #50944
Fixes #50945
Fixes #50946
Fixes #50947
Fixes #50948
Fixes #50999

When setting up functional tests for mobile, the feature switches being used for the tests were misplaced in a broader project, affecting the library tests and causing failures. After moving the feature switches to the scope of functional tests as done in #53253, these test suites no longer fail and can be re-enabled.
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 30, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mdh1418 mdh1418

Labels
area-System.Xml os-android
Projects
No open projects
Triage POD for Reflection, META, etc.
Status: Done
Milestone
7.0.0
3 participants
@steveisok @mdh1418 @buyaa-n