Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure: ConnectAsync_Cancel_ThrowsCancellationException #58355

Closed
karelz opened this issue Aug 30, 2021 · 6 comments
Closed

Test failure: ConnectAsync_Cancel_ThrowsCancellationException #58355

karelz opened this issue Aug 30, 2021 · 6 comments
Labels
area-System.Net test-run-core Test failures in .NET Core test runs
Milestone
9.0.0

Comments

@karelz
Copy link
Member

karelz commented Aug 30, 2021 •
edited
Loading

Test type: System.Net.WebSockets.Client.Tests.CancelTest

Failures 6/30-8/30 (incl. PRs):

Day Run OS
7/16 2x PR #55849 Ubuntu.1804.Amd64.Open - Mono / wasm
8/13 Official run Ubuntu.1604.Amd64.Open - CoreCLR
8/27 PR #58285 Ubuntu.1804.Amd64.Open - Mono / wasm
9/2 PR #57208 windows.10.amd64.server20h1.open.rt - Mono / wasm (pending verification in Kusto)

Failure:

Assert.Throws() Failure
Expected: typeof(System.OperationCanceledException)
Actual:   (No exception was thrown)

   at System.Net.WebSockets.Client.Tests.CancelTest.ConnectAsync_Cancel_ThrowsCancellationException(Uri server) in /_/src/libraries/System.Net.WebSockets.Client/tests/CancelTest.cs:line 27
--- End of stack trace from previous location ---
@karelz karelz added area-System.Net test-run-core Test failures in .NET Core test runs labels Aug 30, 2021
@karelz karelz added this to the Future milestone Aug 30, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Aug 30, 2021
@ghost
Copy link

ghost commented Aug 30, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Test type: System.Net.WebSockets.Client.Tests.CancelTest

Failures 6/30-8/30 (incl. PRs):

Day Run OS
7/16 2x PR #55849 Ubuntu.1804.Amd64.Open - Mono / wasm
8/13 Official run Ubuntu.1604.Amd64.Open - CoreCLR
8/27 PR #58285 Ubuntu.1804.Amd64.Open - Mono / wasm

Failure:

Assert.Throws() Failure
Expected: typeof(System.OperationCanceledException)
Actual:   (No exception was thrown)

   at System.Net.WebSockets.Client.Tests.CancelTest.ConnectAsync_Cancel_ThrowsCancellationException(Uri server) in /_/src/libraries/System.Net.WebSockets.Client/tests/CancelTest.cs:line 27
--- End of stack trace from previous location ---
Author: karelz
Assignees: -
Labels:

area-System.Net, test-run-core
Milestone: Future

@karelz karelz removed the untriaged New issue has not been triaged by the area owner label Aug 30, 2021
@mdh1418

This comment has been minimized.

Sign in to view
@ManickaP ManickaP mentioned this issue Sep 21, 2021
Merged
@CarnaViire
Copy link
Member

There's a recent spike in failures for the test for coreclr, noticed in #59204

Count Date Branch OS
108 2021-09-21 main, pr #59204 "osx.1014.amd64","osx.1015.amd64","sles.15.amd64","centos.8.amd64","windows.81.amd64","debian.10.amd64","debian.11.amd64","fedora.34.amd64","ubuntu.1804.amd64","ubuntu.1604.amd64","windows.10.amd64.server19h1.es","alpine.312.amd64","windows.11.amd64.clientpre","osx.1100.arm64","redhat.7.amd64","windows.10.amd64.server19h1","sles.12.amd64","ubuntu.1910.amd64","windows.nano.1809.amd64","mariner.1.0.amd64","debian.10.arm32","windows.server.core.1909.amd64","debian.11.arm32","windows.10.amd64.serverrs5","windows.7.amd64","osx.1013.amd64","ubuntu.1804.armarch"
82 2021-09-20 main "osx.1100.arm64","osx.1015.amd64","sles.12.amd64","osx.1013.amd64","alpine.312.amd64","debian.10.arm32","debian.11.arm32","osx.1014.amd64","fedora.34.amd64","windows.10.amd64.serverrs5","windows.nano.1809.amd64","debian.10.amd64","ubuntu.1910.amd64","windows.10.amd64.server19h1","windows.81.amd64","mariner.1.0.amd64","sles.15.amd64","redhat.7.amd64","centos.8.amd64","ubuntu.1604.amd64","ubuntu.1804.armarch","windows.7.amd64","ubuntu.1804.amd64","debian.11.amd64"
83 2021-09-19 main "sles.15.amd64","sles.12.amd64","alpine.312.amd64","windows.81.amd64","windows.nano.1809.amd64","windows.10.amd64.server19h1","ubuntu.1910.amd64","mariner.1.0.amd64","windows.10.amd64.serverrs5","windows.7.amd64","redhat.7.amd64","ubuntu.1604.amd64","debian.11.arm32","debian.10.amd64","debian.11.amd64","fedora.34.amd64","ubuntu.1804.amd64","ubuntu.1804.armarch","centos.8.amd64","debian.10.arm32","osx.1014.amd64","osx.1013.amd64","windows.server.core.1909.amd64","osx.1015.amd64","osx.1100.arm64"

@CarnaViire CarnaViire mentioned this issue Sep 30, 2021
Closed
@am11
Copy link
Member

am11 commented Sep 30, 2021

Seems like it has spiked quite significantly in outerloop runs after tweaking made in 360df71.

cc @ViktorHofer noticed many legs are failing on this test.

@VincentBu
Copy link
Contributor

Failed again in: runtime-libraries-coreclr outerloop 20211007.2
Failed test:

net7.0-windows-Release-x64-CoreCLR_release-Windows.81.Amd64.Open
Attempt #1 - System.Net.WebSockets.Client.Tests.CancelTest.ConnectAsync_Cancel_ThrowsCancellationException(server: wss://corefx-net-http11.azurewebsites.net/WebSocket/EchoWebSocket.ashx)

net7.0-windows-Release-x64-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
Attempt #2 - System.Net.WebSockets.Client.Tests.CancelTest.ConnectAsync_Cancel_ThrowsCancellationException(server: wss://corefx-net-http11.azurewebsites.net/WebSocket/EchoWebSocket.ashx)
Attempt #3 - System.Net.WebSockets.Client.Tests.CancelTest.ConnectAsync_Cancel_ThrowsCancellationException(server: wss://corefx-net-http11.azurewebsites.net/WebSocket/EchoWebSocket.ashx)

net7.0-Linux-Release-x64-CoreCLR_release-(Centos.7.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:centos-7-mlnet-helix-20210714125435-dde38af

- Attempt #3 - System.Net.WebSockets.Client.Tests.CancelTest.ConnectAsync_Cancel_ThrowsCancellationException(server: wss://corefx-net-http11.azurewebsites.net/WebSocket/EchoWebSocket.ashx)
- Attempt #2 - System.Net.WebSockets.Client.Tests.CancelTest.ConnectAsync_Cancel_ThrowsCancellationException(server: wss://corefx-net-http11.azurewebsites.net/WebSocket/EchoWebSocket.ashx)

net7.0-OSX-Release-x64-CoreCLR_release-OSX.1014.Amd64.Open

- Attempt #3 - System.Net.WebSockets.Client.Tests.CancelTest.ConnectAsync_Cancel_ThrowsCancellationException(server: wss://corefx-net-http11.azurewebsites.net/WebSocket/EchoWebSocket.ashx)
- Attempt #2 - System.Net.WebSockets.Client.Tests.CancelTest.ConnectAsync_Cancel_ThrowsCancellationException(server: wss://corefx-net-http11.azurewebsites.net/WebSocket/EchoWebSocket.ashx)

Error message:

Assert.Throws() Failure
Expected: typeof(System.OperationCanceledException)
Actual:   (No exception was thrown)


Stack trace
   at System.Net.WebSockets.Client.Tests.CancelTest.ConnectAsync_Cancel_ThrowsCancellationException(Uri server) in /_/src/libraries/System.Net.WebSockets.Client/tests/CancelTest.cs:line 27
--- End of stack trace from previous location ---

@CarnaViire CarnaViire mentioned this issue Oct 8, 2021
Merged
@antonfirsov antonfirsov mentioned this issue Oct 8, 2021
Merged
CarnaViire added a commit that referenced this issue Oct 8, 2021
@CarnaViire
Fix WebSocket cancel test for non-browser (#60173)
17a1e38 
Non-browser WS server used for ConnectAsync_Cancel_ThrowsCancellationException doesn't support "delay20sec", only "delay10sec". This basically reverts the change in this line from #58199 for non-browser platforms.

Contributes to #58355
@rzikm
Copy link
Member

rzikm commented Aug 1, 2024

No recent hits, closing until issue resurfaces.

@rzikm rzikm closed this as completed Aug 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2024
@karelz karelz modified the milestones: Future, 9.0.0 Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Net test-run-core Test failures in .NET Core test runs
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
6 participants
@CarnaViire @am11 @karelz @mdh1418 @rzikm @VincentBu