Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libraries] Skip test suites crashing on CI for iOS/tvOS/MacCatalyst #57208

Merged
merged 38 commits into from
Sep 3, 2021

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Aug 11, 2021

Numerous test suites have been failing for iOS/tvOS/MacCatalyst consistently on CI without useful logs as to why. Moreover, some of these suites pass locally.

This PR looks to reduce the failures on CI by skipping the problematic suites
Skips test suites logged in #53624

ActiveIssues
#58440
#58418
#58367
#58584

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Aug 11, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

The suites for x64 all do not crash locally. Run on CI to see if this is a CI specific crash.
Evaluate #53624

Author: mdh1418
Assignees: -
Labels:

area-Infrastructure-libraries, os-maccatalyst

Milestone: -

@mdh1418 mdh1418 force-pushed the macCatalyst_run_crashing_tests branch from 97b0740 to dc2149a Compare August 16, 2021 15:26
@mdh1418 mdh1418 changed the title Mac catalyst run crashing tests [libraries] Skip test suites crashing on CI for iOS/tvOS/MacCatalyst Aug 17, 2021
@mdh1418 mdh1418 marked this pull request as ready for review August 17, 2021 21:23
@mdh1418 mdh1418 modified the milestone: 7.0.0 Aug 17, 2021
@mdh1418 mdh1418 requested a review from premun August 17, 2021 21:24
@mdh1418 mdh1418 force-pushed the macCatalyst_run_crashing_tests branch 2 times, most recently from 9c4efdd to 5f1d3ba Compare August 19, 2021 17:03
@mdh1418 mdh1418 force-pushed the macCatalyst_run_crashing_tests branch from 3b24e89 to f8854ff Compare August 24, 2021 18:45
@mdh1418
Copy link
Member Author

mdh1418 commented Aug 31, 2021

8/30 CI Completion

After having skipped the failing tests in 8/27 run and adopting the Android trampoline settings. Going to double the settings for trampoine for iOS/MacCatalyst/tvOS

Crashed Suites

Android x64 - NONE

Android x86 - NONE

iOSSim arm64

  • System.Net.Quic.Functional.Tests
  • System.Net.Requests.Tests
  • System.Net.Security.Tests
  • System.Threading.Tasks.Dataflow.Tests
  • System.Threading.Tasks.Tests

iOSSim x64

  • System.Diagnostics.Tracing.Tests
  • System.Net.Quic.Functional.Tests
  • System.Net.Requests.Tests
  • System.Net.Security.Tests
  • System.Text.Json.Tests
  • System.Threading.Tasks.Dataflow.Tests
  • System.Threading.Tasks.Tests

MacCatalyst arm64

  • System.Net.Quic.Functional.Tests
  • System.Net.Requests.Tests
  • System.Net.Security.Tests
  • System.Threading.Tasks.Dataflow.Tests
  • System.Threading.Tasks.Tests

MacCatalyst x64

  • System.Dynamic.Runtime.Tests
  • System.Net.Quic.Functional.Tests
  • System.Net.Requests.Tests
  • System.Net.Security.Tests
  • System.Text.Json.Tests
  • System.Threading.Tasks.Dataflow.Tests
  • System.Threading.Tasks.Tests

tvOSSim x64

  • System.Dynamic.Runtime.Tests
  • System.Net.Quic.Functional.Tests
  • System.Net.Requests.Tests
  • System.Net.Security.Tests
  • System.Text.Json.Tests
  • System.Threading.Tasks.Dataflow.Tests
  • System.Threading.Tasks.Tests

Test Failures

Android x64
System.Security.Cryptography.X509Certificates.Tests - 1

Android x86
System.Security.Cryptography.X509Certificates.Tests - 1

iOSSim arm64 - NONE

iOSSim x64 - NONE

MacCatalyst arm64
System.IO.FileSystem.Watcher.Tests - 1

MacCatalyst x64 - NONE

tvOSSim x64 - NONE

@mdh1418
Copy link
Member Author

mdh1418 commented Aug 31, 2021

8/30 2nd CI Completion

After having skipped the failing tests in 8/30 run and doubling the Android trampoline settings. It seems like trampolines might not be the problem here, so will skip these test suites instead.

Crashed Suites

Android x64 - NONE

Android x86 - NONE

iOSSim arm64

  • System.Net.Quic.Functional.Tests
  • System.Net.Requests.Tests
  • System.Net.Security.Tests
  • System.Threading.Tasks.Dataflow.Tests
  • System.Threading.Tasks.Tests

iOSSim x64

  • System.Dynamic.Runtime.Tests
  • System.Net.Quic.Functional.Tests
  • System.Net.Requests.Tests
  • System.Net.Security.Tests
  • System.Text.Json.Tests
  • System.Threading.Tasks.Dataflow.Tests
  • System.Threading.Tasks.Tests

MacCatalyst arm64

  • System.Net.Quic.Functional.Tests
  • System.Net.Requests.Tests
  • System.Net.Security.Tests
  • System.Text.Json.SourceGeneration.Unit.Tests
  • System.Threading.Channels.Tests
  • System.Threading.Tasks.Dataflow.Tests
  • System.Threading.Tasks.Tests

MacCatalyst x64

  • System.Dynamic.Runtime.Tests
  • System.Net.Quic.Functional.Tests
  • System.Net.Requests.Tests
  • System.Net.Security.Tests
  • System.Text.Json.Tests
  • System.Threading.Tasks.Dataflow.Tests
  • System.Threading.Tasks.Tests

tvOSSim x64

  • System.Dynamic.Runtime.Tests
  • System.Net.Quic.Functional.Tests
  • System.Net.Requests.Tests
  • System.Net.Security.Tests
  • System.Text.Json.Tests
  • System.Threading.Tasks.Dataflow.Tests
  • System.Threading.Tasks.Tests

Test Failures

Android x64 - NONE

Android x86 - NON

iOSSim arm64
System.Tests.TimeZoneInfoTests.IsIanaIdTest
should not be IANA Id.\nExpected: False\nActual: True

iOSSim x64
System.Tests.TimeZoneInfoTests.IsIanaIdTest
should not be IANA Id.\nExpected: False\nActual: True

MacCatalyst arm64
System.Tests.TimeZoneInfoTests.IsIanaIdTest
should not be IANA Id.\nExpected: False\nActual: True

MacCatalyst x64
System.Tests.TimeZoneInfoTests.IsIanaIdTest
should not be IANA Id.\nExpected: False\nActual: True

tvOSSim x64
System.Tests.TimeZoneInfoTests.IsIanaIdTest
should not be IANA Id.\nExpected: False\nActual: True

@mdh1418
Copy link
Member Author

mdh1418 commented Sep 1, 2021

9/1 CI Completion

After having 8x the trampoline settings Android has for iOS/MacCatalyst/tvOS which was already above the defaults, its hard to see what trampoline bump would be reasonable for iOS/MacCatalyst/tvOS. Its not clear what exactly is limiting from the trampolines that causes these suite failures, so this PR will now skip the test suites.

Crashed Suites

Android x64 - NONE

Android x86 - NONE

iOSSim arm64

  • System.Net.Quic.Functional.Tests
  • System.Net.Requests.Tests
  • System.Net.Security.Tests
  • System.Threading.Tasks.Dataflow.Tests
  • System.Threading.Tasks.Tests

iOSSim x64

  • System.Net.Quic.Functional.Tests
  • System.Net.Requests.Tests
  • System.Net.Security.Tests
  • System.Text.Json.Tests
  • System.Threading.Tasks.Dataflow.Tests
  • System.Threading.Tasks.Tests

MacCatalyst arm64

  • System.Net.Quic.Functional.Tests
  • System.Net.Requests.Tests
  • System.Net.Security.Tests
  • System.Threading.Tasks.Dataflow.Tests
  • System.Threading.Tasks.Tests

MacCatalyst x64

  • System.Net.Quic.Functional.Tests
  • System.Net.Requests.Tests
  • System.Net.Security.Tests
  • System.Text.Json.Tests
  • System.Threading.Tasks.Dataflow.Tests
  • System.Threading.Tasks.Tests

tvOSSim x64

  • System.Net.Quic.Functional.Tests
  • System.Net.Requests.Tests
  • System.Net.Security.Tests
  • System.Text.Json.Tests
  • System.Threading.Tasks.Dataflow.Tests
  • System.Threading.Tasks.Tests

Test Failures

Android x64 - NONE

Android x86 - NON

iOSSim arm64 - NONE

iOSSim x64 - NONE

MacCatalyst arm64 - NONE

MacCatalyst x64 - NONE

tvOSSim x64 - NONE

@mdh1418 mdh1418 merged commit 7d58d72 into dotnet:main Sep 3, 2021
@mdh1418 mdh1418 deleted the macCatalyst_run_crashing_tests branch September 3, 2021 17:22
@mdh1418
Copy link
Member Author

mdh1418 commented Sep 8, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1215141145

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2021

@mdh1418 backporting to release/6.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: [MacCatalyst][Libraries] Reenable MacCatalyst x64 crashing test suites
Applying: [MacCatalyst][Libraries] Reenable MacCatalyst arm64 crashing test suites
error: sha1 information is lacking or useless (src/libraries/tests.proj).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 [MacCatalyst][Libraries] Reenable MacCatalyst arm64 crashing test suites
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

steveisok pushed a commit that referenced this pull request Sep 13, 2021
…t and test fixes for Android (#58841)

Manual backport of #57208, #58519, #58562, #58210, #57732, #58428, #58586, #58745, #57687 to release/6.0

Numerous test suites have been failing for iOS/tvOS/MacCatalyst consistently on CI without useful logs as to why. Moreover, some of these suites pass locally.

This PR looks to reduce the failures on CI by skipping the problematic suites
Skips test suites logged in #53624

ActiveIssues
#58440
#58418
#58367
#58584

Co-authored-by: Mitchell Hwang <[email protected]>
Co-authored-by: Alexander Köplinger <[email protected]>
Co-authored-by: Jo Shields <[email protected]>
@ghost ghost locked as resolved and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants