ConfigureHttpClientDefaults isn't an extension method in the reference assembly

[davidfowl]

This PR added ConfigureHttpClientDefaults but it turns out there's a ref/def mismatch that's causing this API to only show up as a static method instead of an extension method:

Ref:
https://github.com/dotnet/runtime/blob/3bda6e0013ddb5b48a7b2a89fd84bf4fbbed0e37/src/libraries/Microsoft.Extensions.Http/ref/Microsoft.Extensions.Http.cs#L60C83-L60C105

Def:

runtime/src/libraries/Microsoft.Extensions.Http/src/DependencyInjection/HttpClientFactoryServiceCollectionExtensions.cs

Line 80 in 3bda6e0

public static IServiceCollection ConfigureHttpClientDefaults(this IServiceCollection services, Action<IHttpClientBuilder> configure)

cc @karelz @JamesNK @CarnaViire @stephentoub

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This PR added ConfigureHttpClientDefaults but it turns out there's a ref/def mismatch that's causing this API to only show up as a static method instead of an extension method:

Ref:
https://github.com/dotnet/runtime/blob/3bda6e0013ddb5b48a7b2a89fd84bf4fbbed0e37/src/libraries/Microsoft.Extensions.Http/ref/Microsoft.Extensions.Http.cs#L60C83-L60C105

Def:

runtime/src/libraries/Microsoft.Extensions.Http/src/DependencyInjection/HttpClientFactoryServiceCollectionExtensions.cs

Line 80 in 3bda6e0

public static IServiceCollection ConfigureHttpClientDefaults(this IServiceCollection services, Action<IHttpClientBuilder> configure)

cc @karelz @JamesNK @CarnaViire @stephentoub

Author:	davidfowl
Assignees:	-
Labels:	untriaged, area-Extensions-HttpClientFactory, needs-area-label
Milestone:	-

[ShreyasJejurkar]

I wonder why PublicApiAnalyzer didn't fail this or warn about it!? 🤔

[CarnaViire]

Reopening for backport

[ShreyasJejurkar]

I wonder why PublicApiAnalyzer didn't fail this or warn about it!? 🤔

This looks like a valid bug in analyzer, we should create issue at given repo. I don't know which repo manages this analyzer. I am out as of now, can someone create a issue for this!?

Thanks,

[CarnaViire]

I wonder why PublicApiAnalyzer didn't fail this or warn about it!? 🤔

cc @ericstj @carlossanlop @ViktorHofer it looks like there might be a bug in API Compat

[ViktorHofer]

I wonder why PublicApiAnalyzer didn't fail this or warn about it!? 🤔

The public API comparison of a contract and implementation assembly is handled by APICompat, not by PublicApiAnalyzer.

I would describe this case as a case that isn't yet covered by APICompat's validation. We have many other cases for which we have issues that aren't yet covered by the tool. See https://github.com/dotnet/sdk/issues?q=is%3Aopen+is%3Aissue+label%3AArea-ApiCompat

[CarnaViire]

Filed an issue dotnet/sdk#34824

[ShreyasJejurkar]

Filed an issue dotnet/sdk#34824

Great! Thanks!

I guess we can close this issue now! 😇

[CarnaViire]

It's open for the backport to release/8.0 branch

[karelz]

Fixed in 8.0 (RC2) in PR #90920 and in 9.0 (main) in PR #90916

[karelz]

13 hours from report to fix in both main and 8.0. That is FAST! Kudos @ShreyasJejurkar and @CarnaViire!

[CarnaViire]

Kudos to @ShreyasJejurkar as well 🥳

[karelz]

Right, @ShreyasJejurkar did the original PR, I entirely forgot. Sorry -- kudos to @ShreyasJejurkar as well! (fixed above)

[ShreyasJejurkar]

13 hours from report to fix in both main and 8.0. That is FAST! Kudos @ShreyasJejurkar and @CarnaViire!

haha, Thanks @karelz and @CarnaViire. I don't think there is anything to appreciate, to be honest, this was a simple fix! 😅
Thanks to @davidfowl who tried the new API actually and found this bug, otherwise I don't know when we would have caught this!

But the major issue is on the API Compact side where this got missed from flagging, I hope there are no more like these cases in the build.

I don't know (am yet to explore) what the code volume needs to go in APICompact to solve this issue, but if anyone here has an idea if it's trivial, it would be great to get that fix so that we can catch this kind of things before release!

@ViktorHofer Thanks for the pointers to APICompact, I wasn't aware as I used to get errors from PublicApiAnalyzer. 😄

But btw this Public API Shipped/UnShipped part of SDK? I mean customers can also use that, is it? I thought this is specifically designed for dotnet repos! 🤔

[ViktorHofer]

But btw this Public API Shipped/UnShipped part of SDK? I mean customers can also use that, is it? I thought this is specifically designed for dotnet repos! 🤔

The Public API Analyzers uses this concept of shipped/unshipped files to track API changes. That analyzer is publicly available to use: https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md

APICompat / PackageValidation is the tool that we use here in runtime, which is also publicly available and even part of the .NET SDK and can be enabled by setting a property. See the documentation here: https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/overview