Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Microsoft.Extensions.Http.cs #90916

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Update Microsoft.Extensions.Http.cs #90916

merged 1 commit into from
Aug 22, 2023

Conversation

ShreyasJejurkar
Copy link
Contributor

@ShreyasJejurkar ShreyasJejurkar commented Aug 22, 2023 •
edited
Loading

Update ref, add missing this to extension method parameter.

Fixes #90911

@ShreyasJejurkar
Update Microsoft.Extensions.Http.cs
89f9b04 
Update ref, add missing `this` to extension method parameter
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 22, 2023
@ghost
Copy link

ghost commented Aug 22, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Update ref, add missing this to extension method parameter

Author: ShreyasJejurkar
Assignees: -
Labels:

new-api-needs-documentation, area-Extensions-HttpClientFactory
Milestone: -

@ShreyasJejurkar ShreyasJejurkar marked this pull request as ready for review August 22, 2023 09:01
@CarnaViire CarnaViire merged commit 4a5695b into dotnet:main Aug 22, 2023
105 checks passed
@CarnaViire
Copy link
Member

/backport to release/8.0

@github-actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5937878078

@github-actions github-actions bot mentioned this pull request Aug 22, 2023
Merged
@karelz karelz added this to the 9.0.0 milestone Aug 22, 2023
@stephentoub
Copy link
Member

@carlossanlop, @ViktorHofer, why wasn't this flagged by our API compat tools?

@ShreyasJejurkar ShreyasJejurkar deleted the ShreyasJejurkar-patch-1 branch August 22, 2023 11:33
@ViktorHofer
Copy link
Member

Similar to dotnet/sdk#23907. Looks like we don't have validation for this scenario yet. Would you mind filing an issue in dotnet/sdk? Implementing such a rule should be trivial.

@CarnaViire
Copy link
Member

Filed an issue dotnet/sdk#34824

@karelz karelz mentioned this pull request Aug 22, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MihaZupan MihaZupan MihaZupan approved these changes

@CarnaViire CarnaViire CarnaViire approved these changes

Assignees
No one assigned
Labels
area-Extensions-HttpClientFactory community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

ConfigureHttpClientDefaults isn't an extension method in the reference assembly
6 participants
@ShreyasJejurkar @CarnaViire @stephentoub @ViktorHofer @MihaZupan @karelz