Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API Compat] Add extension method validation #34824

Closed
CarnaViire opened this issue Aug 22, 2023 · 1 comment · Fixed by #34871
Closed

[API Compat] Add extension method validation #34824

CarnaViire opened this issue Aug 22, 2023 · 1 comment · Fixed by #34871
Labels
Area-ApiCompat untriaged Request triage from a team member

Comments

@CarnaViire
Copy link
Member

CarnaViire commented Aug 22, 2023 •
edited
Loading

Add validation that this modifier is present in ref of the extension method, to prevent issues like this one: dotnet/runtime#90911

Currently, there's no such validation, so it is possible to miss this modifier by accident, if ref is updated manually.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-ApiCompat untriaged Request triage from a team member labels Aug 22, 2023
@ghost
Copy link

ghost commented Aug 22, 2023

@dotnet/area-infrastructure-libraries a new issue has been filed in the ApiCompat area, please triage

This was referenced Aug 22, 2023
Closed
Merged
@karelz karelz mentioned this issue Aug 22, 2023
Merged
ViktorHofer added a commit that referenced this issue Aug 23, 2023
@ViktorHofer
Validate "this" extension methods and limit visibility
6da00ac 
Fixes #34824
@ViktorHofer ViktorHofer mentioned this issue Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-ApiCompat untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate "this" extension methods and limit visibility dotnet/sdk
1 participant
@CarnaViire