Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert some more array FCalls to managed #102739

Merged
merged 53 commits into from
Jun 27, 2024
Merged

Conversation

huoyaoyuan
Copy link
Member

@huoyaoyuan huoyaoyuan commented May 28, 2024

Merge IsSimpleCopy and CanAssignArrayType again.
Reused code for PrimitiveWiden.

Also include InitializeArray and GetSpanDataFrom. They are expanded in JIT so the managed definition is less performance critical.

There would be no more FCalls in Array type now.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 28, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 28, 2024
@huoyaoyuan huoyaoyuan added area-VM-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 28, 2024
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

{
switch (pMT->ComponentSize)
{
case 1:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use sizeof(byte) and corresponding primitives for this switch statement?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using such pattern in CoreLib. Sounds reasonable.

src/coreclr/vm/comutilnative.cpp Show resolved Hide resolved
src/coreclr/vm/reflectioninvocation.cpp Outdated Show resolved Hide resolved
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Co-authored-by: Aaron Robinson <[email protected]>
@jkotas
Copy link
Member

jkotas commented Jun 27, 2024

The timeout tests passed before a minor comment-only change

@jkotas jkotas merged commit 2d2d59c into dotnet:main Jun 27, 2024
135 of 149 checks passed
@jkotas
Copy link
Member

jkotas commented Jun 27, 2024

Thank you!

@huoyaoyuan huoyaoyuan deleted the array-fcall branch June 27, 2024 06:43
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants