Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert some more array FCalls to managed #102739

Merged
merged 53 commits into from
Jun 27, 2024
Merged

Convert some more array FCalls to managed #102739

merged 53 commits into from
Jun 27, 2024

Commits on May 27, 2024

  1. Implement IsSimpleCopy and CanAssignArrayType in managed code

    @huoyaoyuan
    huoyaoyuan committed May 27, 2024
    Configuration menu
    Copy the full SHA
    566b15e View commit details
    Browse the repository at this point in the history

  2. Fold IsSimpleCopy back to CanAssignArrayType

    @huoyaoyuan
    huoyaoyuan committed May 27, 2024
    Configuration menu
    Copy the full SHA
    8a592b9 View commit details
    Browse the repository at this point in the history

  3. Delete FCall and QCall definitions for copy

    @huoyaoyuan
    huoyaoyuan committed May 27, 2024
    Configuration menu
    Copy the full SHA
    0dce3d4 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Convert InternalSetValue to managed

    @huoyaoyuan
    huoyaoyuan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    d29e5d8 View commit details
    Browse the repository at this point in the history

  2. Setup FCalls

    @huoyaoyuan
    huoyaoyuan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    5dd0e3c View commit details
    Browse the repository at this point in the history

  3. Remove FCall for GetCorElementTypeOfElementType

    @huoyaoyuan
    huoyaoyuan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    527021c View commit details
    Browse the repository at this point in the history

  4. Complete TryUnBox

    @huoyaoyuan
    huoyaoyuan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    e7d843a View commit details
    Browse the repository at this point in the history

  5. Fix FCall definition

    @huoyaoyuan
    huoyaoyuan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    2bb5fe7 View commit details
    Browse the repository at this point in the history

  6. Implement InitializeArray in managed

    @huoyaoyuan
    huoyaoyuan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    f7da172 View commit details
    Browse the repository at this point in the history

  7. Implement GetSpanDataFrom in managed

    @huoyaoyuan
    huoyaoyuan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    0924555 View commit details
    Browse the repository at this point in the history

  8. Remove FCall definition

    @huoyaoyuan
    huoyaoyuan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    dc85381 View commit details
    Browse the repository at this point in the history

  9. Fix RVA field address

    @huoyaoyuan
    huoyaoyuan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    f99c553 View commit details
    Browse the repository at this point in the history

  10. Fix RVA assert

    @huoyaoyuan
    huoyaoyuan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    c5e6cc4 View commit details
    Browse the repository at this point in the history

  11. Do not use hydrated RtFieldInfo

    @huoyaoyuan
    huoyaoyuan committed May 28, 2024
    Configuration menu
    Copy the full SHA
    470b86f View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Use QCall for LoadSize

    @huoyaoyuan
    huoyaoyuan committed May 29, 2024
    Configuration menu
    Copy the full SHA
    c7821e6 View commit details
    Browse the repository at this point in the history

  2. Fix CanAssignArrayType condition

    @huoyaoyuan
    huoyaoyuan committed May 29, 2024
    Configuration menu
    Copy the full SHA
    5225203 View commit details
    Browse the repository at this point in the history

  3. Fix compilation

    @huoyaoyuan
    huoyaoyuan committed May 29, 2024
    Configuration menu
    Copy the full SHA
    07293e3 View commit details
    Browse the repository at this point in the history

  4. Simplify AssignType enum

    @huoyaoyuan
    huoyaoyuan committed May 29, 2024
    Configuration menu
    Copy the full SHA
    5da88c3 View commit details
    Browse the repository at this point in the history

  5. Fix I and U in CanPrimitiveWiden

    @huoyaoyuan
    huoyaoyuan committed May 29, 2024
    Configuration menu
    Copy the full SHA
    5222bca View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. CanCastTo should be QCall

    @huoyaoyuan
    huoyaoyuan committed May 30, 2024
    Configuration menu
    Copy the full SHA
    335b2fb View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Remove ThrowHelper usages that not in hot path

    @huoyaoyuan
    huoyaoyuan committed May 31, 2024
    Configuration menu
    Copy the full SHA
    93ec9d8 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Merge branch 'main' into array-fcall

    @huoyaoyuan
    huoyaoyuan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c3f5097 View commit details
    Browse the repository at this point in the history

  2. Revert the known broken InternalSetValue

    @huoyaoyuan
    huoyaoyuan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    481e4d4 View commit details
    Browse the repository at this point in the history

  3. Revert "Revert the known broken InternalSetValue" 

    This reverts commit 481e4d4.
    @huoyaoyuan
    huoyaoyuan committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a266a30 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Fix heap overwrite

    @huoyaoyuan
    huoyaoyuan committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    b8e4584 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2024

  1. Add disabled test for RVA field reflection

    @huoyaoyuan
    huoyaoyuan committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    5465a97 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Push back changes around IsSimpleCopy and CanAssignArrayType

    @huoyaoyuan
    huoyaoyuan committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    4ce4f51 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Move PrimitiveWiden to InvokeUtils

    @huoyaoyuan
    huoyaoyuan committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    30b7d8f View commit details
    Browse the repository at this point in the history

  2. Merge coreclr specific InvokeUtils

    @huoyaoyuan
    huoyaoyuan committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    8a9c5bc View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Revert "Merge coreclr specific InvokeUtils" 

    This reverts commit 8a9c5bc.
    @huoyaoyuan
    huoyaoyuan committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    f95fa34 View commit details
    Browse the repository at this point in the history

  2. Move InvokeUtils to shared

    @huoyaoyuan
    huoyaoyuan committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    ebfd224 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Jan Kotas <[email protected]>
    @huoyaoyuan @jkotas
    huoyaoyuan and jkotas committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    d9205c6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into array-fcall

    @huoyaoyuan
    huoyaoyuan committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    7eef724 View commit details
    Browse the repository at this point in the history

  3. Fix trailing whitespace

    @huoyaoyuan
    huoyaoyuan committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    8cfb58f View commit details
    Browse the repository at this point in the history

  4. Reduce QCalls

    @huoyaoyuan
    huoyaoyuan committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    fbb9d71 View commit details
    Browse the repository at this point in the history

  5. Reduce CorElementType overhead

    @huoyaoyuan
    huoyaoyuan committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    324df76 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Separate RVA reflection change out

    @huoyaoyuan
    huoyaoyuan committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    089ae12 View commit details
    Browse the repository at this point in the history

  2. Revert GetCorElementTypeOfElementType

    @huoyaoyuan
    huoyaoyuan committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    a5e7441 View commit details
    Browse the repository at this point in the history

  3. Change the MethodTable FCall to be optimal for primitive and share wi… 

    …th enum
    @huoyaoyuan
    huoyaoyuan committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    5552d63 View commit details
    Browse the repository at this point in the history

  4. Return ref from GetSpanDataFrom

    @huoyaoyuan
    huoyaoyuan committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    133cd8a View commit details
    Browse the repository at this point in the history

  5. Handle enum conversion to underlying type

    @huoyaoyuan
    huoyaoyuan committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    e17bf0e View commit details
    Browse the repository at this point in the history

  6. Update exception message

    @huoyaoyuan
    huoyaoyuan committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    dd1e2dd View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Add KeepAlive

    @huoyaoyuan
    huoyaoyuan committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    32b8789 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary qcall handle

    @huoyaoyuan
    huoyaoyuan committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    582eaf1 View commit details
    Browse the repository at this point in the history

  3. Fix ref src

    @huoyaoyuan
    huoyaoyuan committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    1836ae5 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Update FCall name and assert

    @huoyaoyuan
    huoyaoyuan committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    cb6aa00 View commit details
    Browse the repository at this point in the history

  2. Remove unused changes

    @huoyaoyuan
    huoyaoyuan committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    49cf866 View commit details
    Browse the repository at this point in the history

  3. Use void* for address

    @huoyaoyuan
    huoyaoyuan committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    7a0c398 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Aaron Robinson <[email protected]>
Co-authored-by: Jan Kotas <[email protected]>
    @huoyaoyuan @AaronRobinsonMSFT @jkotas
    3 people committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    db677ad View commit details
    Browse the repository at this point in the history

  2. Remove unused enum FCall

    @huoyaoyuan
    huoyaoyuan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    353715e View commit details
    Browse the repository at this point in the history

  3. Use sizeof

    @huoyaoyuan
    huoyaoyuan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    8fb1c96 View commit details
    Browse the repository at this point in the history

  4. Add some comment

    @huoyaoyuan
    huoyaoyuan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    26d4c80 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Add comment to lifetime 

    Co-authored-by: Aaron Robinson <[email protected]>
    @huoyaoyuan @AaronRobinsonMSFT
    huoyaoyuan and AaronRobinsonMSFT committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5f7263f View commit details
    Browse the repository at this point in the history