Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete VectorT size constants from minipal/cpufeatures #102946

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Delete VectorT size constants from minipal/cpufeatures #102946

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9720e0d
Delete VectorT size constants from minipal/cpufeatures
jkotas May 31, 2024
3f96534
Fix arm64
jkotas Jun 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions src/coreclr/tools/Common/Compiler/HardwareIntrinsicHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,9 @@ private static class XArchIntrinsicConstants
public const int Avx512Vbmi = 0x800000;
public const int Avx512Vbmi_vl = 0x1000000;
public const int Serialize = 0x2000000;
public const int VectorT128 = 0x4000000;
public const int VectorT256 = 0x8000000;
public const int VectorT512 = 0x10000000;
public const int Avx10v1 = 0x20000000;
public const int Avx10v1_v256 = 0x40000000;
public const int Avx10v1_v512 = unchecked((int)0x80000000);
public const int Avx10v1 = 0x4000000;
public const int Avx10v1_v256 = 0x8000000;
public const int Avx10v1_v512 = 0x10000000;

public static void AddToBuilder(InstructionSetSupportBuilder builder, int flags)
{
Expand Down Expand Up @@ -228,9 +225,9 @@ public static int FromInstructionSet(InstructionSet instructionSet)
InstructionSet.X64_X86Base_X64 => 0,

// Vector<T> Sizes
InstructionSet.X64_VectorT128 => VectorT128,
InstructionSet.X64_VectorT256 => VectorT256,
InstructionSet.X64_VectorT512 => VectorT512,
InstructionSet.X64_VectorT128 => 0,
InstructionSet.X64_VectorT256 => Avx2,
InstructionSet.X64_VectorT512 => Avx512f,

_ => throw new NotSupportedException(((InstructionSet_X64)instructionSet).ToString())
};
Expand Down Expand Up @@ -310,7 +307,7 @@ public static int FromInstructionSet(InstructionSet instructionSet)
InstructionSet.ARM64_Sve_Arm64 => Sve,

// Vector<T> Sizes
InstructionSet.ARM64_VectorT128 => VectorT128,
InstructionSet.ARM64_VectorT128 => AdvSimd,

_ => throw new NotSupportedException(((InstructionSet_ARM64)instructionSet).ToString())
};
Expand Down
19 changes: 4 additions & 15 deletions src/coreclr/vm/codeman.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1258,29 +1258,18 @@ void EEJitManager::SetCpuInfo()
int cpuFeatures = minipal_getcpufeatures();

#if defined(TARGET_X86) || defined(TARGET_AMD64)

#if defined(TARGET_X86) && !defined(TARGET_WINDOWS)
// Linux may still support no SSE/SSE2 for 32-bit
if ((cpuFeatures & XArchIntrinsicConstants_VectorT128) == 0)
{
EEPOLICY_HANDLE_FATAL_ERROR_WITH_MESSAGE(COR_E_EXECUTIONENGINE, W("SSE and SSE2 processor support required."));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can figure out how to add this back if we care enough about 32-bit Linux on ancient hardware (I do not not.)

}
#else
_ASSERTE((cpuFeatures & XArchIntrinsicConstants_VectorT128) != 0);
#endif

CPUCompileFlags.Set(InstructionSet_VectorT128);

// Get the maximum bitwidth of Vector<T>, rounding down to the nearest multiple of 128-bits
uint32_t maxVectorTBitWidth = (CLRConfig::GetConfigValue(CLRConfig::EXTERNAL_MaxVectorTBitWidth) / 128) * 128;

if (((cpuFeatures & XArchIntrinsicConstants_VectorT256) != 0) && ((maxVectorTBitWidth == 0) || (maxVectorTBitWidth >= 256)))
if (((cpuFeatures & XArchIntrinsicConstants_Avx2) != 0) && ((maxVectorTBitWidth == 0) || (maxVectorTBitWidth >= 256)))
{
// We allow 256-bit Vector<T> by default
CPUCompileFlags.Set(InstructionSet_VectorT256);
}

if (((cpuFeatures & XArchIntrinsicConstants_VectorT512) != 0) && (maxVectorTBitWidth >= 512))
if (((cpuFeatures & XArchIntrinsicConstants_Avx512f) != 0) && (maxVectorTBitWidth >= 512))
{
// We require 512-bit Vector<T> to be opt-in
CPUCompileFlags.Set(InstructionSet_VectorT512);
Expand Down Expand Up @@ -1458,12 +1447,12 @@ void EEJitManager::SetCpuInfo()

#if !defined(TARGET_WINDOWS)
// Linux may still support no AdvSimd
if ((cpuFeatures & ARM64IntrinsicConstants_VectorT128) == 0)
if ((cpuFeatures & ARM64IntrinsicConstants_AdvSimd) == 0)
{
EEPOLICY_HANDLE_FATAL_ERROR_WITH_MESSAGE(COR_E_EXECUTIONENGINE, W("AdvSimd processor support required."));
}
#else
_ASSERTE((cpuFeatures & ARM64IntrinsicConstants_VectorT128) != 0);
_ASSERTE((cpuFeatures & ARM64IntrinsicConstants_AdvSimd) != 0);
#endif

CPUCompileFlags.Set(InstructionSet_VectorT128);
Expand Down
Loading
Loading