Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test CI #102967

Closed
wants to merge 40 commits into from
Closed

Test CI #102967

wants to merge 40 commits into from

Conversation

huoyaoyuan
Copy link
Member

Investigating GC hole of #102739

@huoyaoyuan
Implement IsSimpleCopy and CanAssignArrayType in managed code
566b15e
@huoyaoyuan
Fold IsSimpleCopy back to CanAssignArrayType
8a592b9
@huoyaoyuan
Delete FCall and QCall definitions for copy
0dce3d4
@huoyaoyuan
Convert InternalSetValue to managed
d29e5d8
@huoyaoyuan
Setup FCalls
5dd0e3c
@huoyaoyuan
Remove FCall for GetCorElementTypeOfElementType
527021c
@huoyaoyuan
Complete TryUnBox
e7d843a
@huoyaoyuan
Fix FCall definition
2bb5fe7
@huoyaoyuan
Implement InitializeArray in managed
f7da172
@huoyaoyuan
Implement GetSpanDataFrom in managed
0924555
@huoyaoyuan
Remove FCall definition
dc85381
@huoyaoyuan
Fix RVA field address
f99c553
@huoyaoyuan
Fix RVA assert
c5e6cc4
@huoyaoyuan
Do not use hydrated RtFieldInfo
470b86f
@huoyaoyuan
Use QCall for LoadSize
c7821e6
@huoyaoyuan
Fix CanAssignArrayType condition
5225203
@huoyaoyuan
Fix compilation
07293e3
@huoyaoyuan
Simplify AssignType enum
5da88c3
@huoyaoyuan
Fix I and U in CanPrimitiveWiden
5222bca
@huoyaoyuan
CanCastTo should be QCall
335b2fb
@huoyaoyuan
Remove ThrowHelper usages that not in hot path
93ec9d8
@huoyaoyuan
Revert
44445a3
@huoyaoyuan
GetCorElementTypeOfElementType
b59fa9d
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 2, 2024
@huoyaoyuan huoyaoyuan added the NO-REVIEW Experimental/testing PR, do NOT review it label Jun 2, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 2, 2024
@jkotas
Copy link
Member

jkotas commented Jun 2, 2024

FWIW, you can split your PR into multiple smaller ones for real, not just for testing. It will make it easier to get the changes in.

@huoyaoyuan
Copy link
Member Author

FWIW, you can split your PR into multiple smaller ones for real, not just for testing.

I tested locally and every part seems to cause System.Runtime failing. I'm trying to investigate more and avoid false negative.

@build-analysis build-analysis bot mentioned this pull request Jun 2, 2024
Closed
This was referenced Jun 4, 2024
Closed
Closed
@huoyaoyuan huoyaoyuan closed this Jun 4, 2024
@huoyaoyuan huoyaoyuan reopened this Jun 4, 2024
@build-analysis build-analysis bot mentioned this pull request Jun 4, 2024
Open
3 tasks
This was referenced Jun 5, 2024
Open
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Jun 6, 2024
Closed
This was referenced Jun 6, 2024
Closed
Closed
@huoyaoyuan huoyaoyuan closed this Jun 6, 2024
@huoyaoyuan huoyaoyuan deleted the array-fcall-test branch June 6, 2024 13:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners NO-REVIEW Experimental/testing PR, do NOT review it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huoyaoyuan @jkotas