Stored the initial capacity of the ConcurrentDictionary for correctly sizing the backing array after clearing the collection. #108065
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sizing the backing array after clearing the collection. * Stored the capacity in the ctor. * Used the stored capacity in Clear(). Fixes dotnet#107016
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-collections |
3 tasks
eiriktsarpalis
approved these changes
Sep 20, 2024
There is precedent in us using reflection to check intentional properties of collections types. Not sure if warranted here, but bare minimum you should try to check if there is test coverage for passing a large-ish capacity parameter and then clearing the collection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107016