-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determinism fixes #306
Merged
fadimounir
merged 10 commits into
dotnet:master
from
SrivastavaAnubhav:determinism-fixes
Dec 3, 2019
Merged
Determinism fixes #306
fadimounir
merged 10 commits into
dotnet:master
from
SrivastavaAnubhav:determinism-fixes
Dec 3, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SrivastavaAnubhav
commented
Nov 26, 2019
- NativeFormatWriter's HashTable save now uses OrderBy, so the output deterministic if the values are entered deterministically
- Make GetILBytes in EcmaMethodIL threadsafe so we don't accidentally get two different addresses for the same code
- Fix ManifestMetadataTableNode bug where we were incrementing nextModuleId unnecessarily sometimes. Also added a check that we have finishing sorting the object nodes, since we require that they are sorted to get deterministic output here.
- Do not flush the ILCache before compiling all methods in a batch. This might have caused the same MethodDesc to have two different MethodIL objects.
- Add a determinism test that compiles all of coreroot with two different seeds
…areExchange. Remove comment saying that ILCache would eventually be removed. Fix ModuleToIndex not adding all assemblies.
…in ManifestMetadataTableNode.
@dotnet/crossgen-contrib |
jaredpar
reviewed
Nov 26, 2019
fadimounir
reviewed
Nov 27, 2019
src/coreclr/tests/src/readytorun/coreroot_determinism/coreroot_determinism.csproj
Outdated
Show resolved
Hide resolved
fadimounir
reviewed
Nov 27, 2019
src/coreclr/tests/src/readytorun/coreroot_determinism/Program.cs
Outdated
Show resolved
Hide resolved
fadimounir
reviewed
Nov 27, 2019
src/coreclr/tests/src/readytorun/coreroot_determinism/Program.cs
Outdated
Show resolved
Hide resolved
fadimounir
reviewed
Nov 27, 2019
src/coreclr/tests/src/readytorun/coreroot_determinism/Program.cs
Outdated
Show resolved
Hide resolved
fadimounir
suggested changes
Nov 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I have a few suggestions concerning the test
… of stopping at the first failure. Use CompareExchange for GetLocals and GetExceptionRegions as well.
… exists before creating a new one.
jaredpar
reviewed
Dec 2, 2019
...sgen2/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/NewArrayFixupSignature.cs
Outdated
Show resolved
Hide resolved
fadimounir
approved these changes
Dec 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.