Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determinism fixes #306

Merged
merged 10 commits into from
Dec 3, 2019
Merged

Determinism fixes #306

merged 10 commits into from
Dec 3, 2019

Commits on Nov 26, 2019

  1. More determinism fixes.

    Anubhav Srivastava committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    320a5dd View commit details
    Browse the repository at this point in the history

  2. Address PR comments. Replace lock in GetILBytes with Interlocked.Comp… 

    …areExchange. Remove comment saying that ILCache would eventually be removed. Fix ModuleToIndex not adding all assemblies.
    Anubhav Srivastava committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    b2e59fc View commit details
    Browse the repository at this point in the history

  3. Add determinism test that compiles CORE_ROOT with two seeds. Fix nit … 

    …in ManifestMetadataTableNode.
    Anubhav Srivastava committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    12518d4 View commit details
    Browse the repository at this point in the history

  4. Fix spacing.

    Anubhav Srivastava committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    b881d89 View commit details
    Browse the repository at this point in the history

  5. Re-add required import.

    Anubhav Srivastava committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    13ad163 View commit details
    Browse the repository at this point in the history

  6. Fix bash CLR pre-commands.

    Anubhav Srivastava committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    91b3996 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2019

  1. Address PR comments. Remove batch precommands. Diff all files instead… 

    … of stopping at the first failure. Use CompareExchange for GetLocals and GetExceptionRegions as well.
    Anubhav Srivastava committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    532863f View commit details
    Browse the repository at this point in the history

  2. Check files exist before diff'ing them. Remove output directory if it… 

    … exists before creating a new one.
    Anubhav Srivastava committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    9510b57 View commit details
    Browse the repository at this point in the history

  3. Fix environment variable case.

    Anubhav Srivastava committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    4595444 View commit details
    Browse the repository at this point in the history

  4. Fix indentation

    Anubhav Srivastava committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    d1cdf44 View commit details
    Browse the repository at this point in the history