Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUIC] Fix TestConnect #49660

Merged
merged 2 commits into from
Mar 17, 2021
Merged

[QUIC] Fix TestConnect #49660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8778f9c
Mark all failing tests with ActiveIssue
CarnaViire Mar 4, 2021
525aa36
Fix TestConnect
CarnaViire Mar 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ public async Task SetListenerTimeoutWorksWithSmallTimeout()
await Assert.ThrowsAsync<QuicOperationAbortedException>(async () => await serverConnection.AcceptStreamAsync().TimeoutAfter(100000));
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not running these in CI AFAIK so the failures are not blocking any PRs. This will disable them for our local runs, is that what you're goal here is?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it is for us to have a clean local test run, since we are to start adding new changes. So if some new failures appear, we will know it was because of our changes

[Theory]
[MemberData(nameof(WriteData))]
public async Task WriteTests(int[][] writes, WriteType writeType)
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/System.Net.Quic/tests/FunctionalTests/QuicConnectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ public abstract class QuicConnectionTests<T> : QuicTestBase<T>
public async Task TestConnect()
{
using QuicListener listener = CreateQuicListener();

listener.Start();
IPEndPoint listenEndPoint = listener.ListenEndPoint;

using QuicConnection clientConnection = CreateQuicConnection(listenEndPoint);
Expand Down
44 changes: 44 additions & 0 deletions ...raries/System.Net.Quic/tests/FunctionalTests/QuicStreamConnectedStreamConformanceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,50 @@ public sealed class MsQuicQuicStreamConformanceTests : QuicStreamConformanceTest
[ActiveIssue("https://github.com/dotnet/runtime/issues/756")]
public override Task Parallel_ReadWriteMultipleStreamsConcurrently() => base.Parallel_ReadWriteMultipleStreamsConcurrently();

// TODO: new additions, find out the actual reason for hanging
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task ReadTimeout_Expires_Throws() => base.ReadTimeout_Expires_Throws();
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task ConcurrentBidirectionalReadsWrites_Success() => base.ConcurrentBidirectionalReadsWrites_Success();
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task ArgumentValidation_ThrowsExpectedException() => base.ArgumentValidation_ThrowsExpectedException();
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task ReadWriteAsync_PrecanceledOperations_ThrowsCancellationException() => base.ReadWriteAsync_PrecanceledOperations_ThrowsCancellationException();
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task Read_DataStoredAtDesiredOffset(ReadWriteMode mode) => base.Read_DataStoredAtDesiredOffset(mode);
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task ReadAsync_CancelPendingRead_DoesntImpactSubsequentReads() => base.ReadAsync_CancelPendingRead_DoesntImpactSubsequentReads();
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task Disposed_ThrowsObjectDisposedException() => base.Disposed_ThrowsObjectDisposedException();
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task Timeout_Roundtrips() => base.Timeout_Roundtrips();
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task ZeroByteWrite_OtherDataReceivedSuccessfully(ReadWriteMode mode) => base.ZeroByteWrite_OtherDataReceivedSuccessfully(mode);
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task ReadAsync_ContinuesOnCurrentTaskSchedulerIfDesired(bool flowExecutionContext, bool? continueOnCapturedContext) => base.ReadAsync_ContinuesOnCurrentTaskSchedulerIfDesired(flowExecutionContext, continueOnCapturedContext);
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task ZeroByteRead_BlocksUntilDataAvailableOrNops(ReadWriteMode mode) => base.ZeroByteRead_BlocksUntilDataAvailableOrNops(mode);
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task ReadAsync_CancelPendingTask_ThrowsCancellationException() => base.ReadAsync_CancelPendingTask_ThrowsCancellationException();
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task ReadAsync_ContinuesOnCurrentSynchronizationContextIfDesired(bool flowExecutionContext, bool? continueOnCapturedContext) => base.ReadAsync_ContinuesOnCurrentSynchronizationContextIfDesired(flowExecutionContext, continueOnCapturedContext);
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task ReadWriteByte_Success() => base.ReadWriteByte_Success();
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task ReadWrite_Success(ReadWriteMode mode, int writeSize, bool startWithFlush) => base.ReadWrite_Success(mode, writeSize, startWithFlush);
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task ReadWrite_Success_Large(ReadWriteMode mode, int writeSize, bool startWithFlush) => base.ReadWrite_Success_Large(mode, writeSize, startWithFlush);
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task Flush_ValidOnWriteableStreamWithNoData_Success() => base.Flush_ValidOnWriteableStreamWithNoData_Success();
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task ReadAsync_CancelPendingValueTask_ThrowsCancellationException() => base.ReadAsync_CancelPendingValueTask_ThrowsCancellationException();
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task ReadAsync_DuringReadAsync_ThrowsIfUnsupported() => base.ReadAsync_DuringReadAsync_ThrowsIfUnsupported();
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task ReadWrite_CustomMemoryManager_Success(bool useAsync) => base.ReadWrite_CustomMemoryManager_Success(useAsync);
[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
public override Task Flush_ValidOnReadableStream_Success() => base.Flush_ValidOnReadableStream_Success();

}

public abstract class QuicStreamConformanceTests : ConnectedStreamConformanceTests
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Net.Quic/tests/FunctionalTests/QuicStreamTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ public async Task BasicTest()
}
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
[Fact]
public async Task MultipleReadsAndWrites()
{
Expand Down Expand Up @@ -228,6 +229,7 @@ public async Task GetStreamIdWithoutStartWorks()
Assert.Equal(0, clientStream.StreamId);
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/49157")]
[Fact]
public async Task LargeDataSentAndReceived()
{
Expand Down