-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added runtime dependency to fix the intermittent test failures #54587
Conversation
Tagging subscribers to this area: @CoffeeFlux Issue DetailsFixed the intermittent test failures caused by mono-config.json being loaded out of order
|
@kg Is this what you meant? Also, can you please add the necessary reviewers. I still don't have access to do it. |
Module.config = await MONO.mono_wasm_load_config("./mono-config.json"); | ||
Module.removeDependency('mono-config.json'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation got mucked up here
It might make sense to hoist all this complexity into mono_wasm_load_config, and introduce a 'mono_wasm_load_config_async' which adds the dependency, kicks off the async load, then removes the dependency. That way you don't have to touch all these files any time something changes, and it's easy for people to properly imitate the pattern. |
Sorry, I was rushing. Haha this is straight from my nightmares. Also, I can't test it locally since my local machine's build is currently messed up |
a6e0409
to
8ac6755
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pass configFilePath as the
Looks like the tests that were failing for Ankit and Katelyn now pass |
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsFixed the intermittent test failures caused by mono-config.json being loaded out of order
|
This is a JavaScript only change that cannot impact the other failing lanes. |
…nitial_config * origin/main: (362 commits) [wasm][debugger] Reuse debugger-agent on wasm debugger (dotnet#52300) Put Crossgen2 in sync with dotnet#54235 (dotnet#54438) Move System.Object serialization to ObjectConverter (dotnet#54436) Move setting fHasVirtualStaticMethods out of sanity check section (dotnet#54574) [wasm] Compile .bc->.o in parallel, before passing to the linker (dotnet#54053) Change PathInternal.IsCaseSensitive to a constant (dotnet#54340) Make mono_polling_required a public symbol (dotnet#54592) Respect EventSource::IsSupported setting in more codepaths (dotnet#51977) Root ComActivator for hosting (dotnet#54524) Add ILLink annotations to S.D.Common related to DbConnectionStringBuilder (dotnet#54280) Fix finalizer issue with regions (dotnet#54550) Add support for multi-arch install locations (dotnet#53763) Update library testing docs page to reduce confusion (dotnet#54324) [FileStream] handle UNC and device paths (dotnet#54483) Update NetAnalyzers version (dotnet#54511) Added runtime dependency to fix the intermittent test failures (dotnet#54587) Disable failing System.Reflection.Tests.ModuleTests.GetMethods (dotnet#54564) [wasm] Move AOT builds from `runtime-staging` to `runtime` (dotnet#54577) Keep obj node for ArrayIndex. (dotnet#54584) Disable another failing MemoryCache test (dotnet#54578) ...
Fixed the intermittent test failures caused by mono-config.json being loaded out of order