Use new Hosted build pools #58484
Merged
Use new Hosted build pools #58484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsWe are transitioning all servicing builds to a new set of build pools
|
|
Same as #57785 |
MattGal
reviewed
Sep 1, 2021
| @@ -55,11 +55,11 @@ jobs: | |||
| testDisplayName: ${{ parameters.runtimeFlavor }}_interpreter_${{ parameters.liveRuntimeBuildConfig }} | |||
|
|
|||
| # To run the tests we just send to helix and wait, use ubuntu hosted pools for faster providing and to not back up our build pools | |||
| ${{ if startsWith(parameters.pool.queue, 'BuildPool.Ubuntu') }}: | |||
| ${{ if startsWith(parameters.pool.queue, 'Build.Ubuntu') }}: | |||
There was a problem hiding this comment.
I'm not sure I agree with this sentiment. I favor as many machines as can be of the 200 parallelism limit be macOS since ostensibly 1ES can handle these but not MacOS
There was a problem hiding this comment.
This change is not correct anyway, as the new pool property is demands and it doesn't start with Build.Ubuntu.
pool.queue no longer exists after this change. So we can safely delete this as now are a no-op.
MattGal
approved these changes
Sep 1, 2021
ViktorHofer
approved these changes
Sep 2, 2021
|
cc @danmoseley (tell-mode) |
Merged
radical
added a commit
to radical/runtime
that referenced
this pull request
Sep 16, 2021
This reverts commit 0e71ebc.
radical
added a commit
to radical/runtime
that referenced
this pull request
Sep 16, 2021
This reverts commit 0e71ebc.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are transitioning all servicing builds to a new set of build pools